Prototype Planetologist movement and Special-card battles

Connect capped extra range, two-origin gathering, Fremen cancellation and
saved replacement choices. Add human controls and actual first-choice AI
paths for all four profiles. Admit the exact nine base green Specials in
the actual skilled leader's weapon slot for +2 on survival, with mandatory
physical discard and no native utility effect. Reject stale dead-disc plans.

Independent movement/battle review closed after the saved-dead-disc fix.
84 focused tests passed. Two four-profile Basic/Advanced samples completed
(194/186 accepted actions, six JSON restorations each, zero rejected actions).
Basic used both movement branches; Advanced used added range. Browser genuine
setup/gather/refresh and a separate targeted Special/traitor-loss fixture passed.

Required verification: types, lint, 4435 offline tests, build and 43 HTTP tests
passed. First attempt stopped at missing explicit test promise markers;
corrected before the successful broad run. Final check/build/HTTP durations:
144157/6638/25048 ms. Source fingerprint (1260 files):
bb7be69cf3e925bf7338ea444f77279ed7b37faadc3c44ed7db01b941f27b861
Private report: checkpoints/20260913-planetologist/checks-final/report.json.

Preserved all 325 opening games and all original application/seat/recovery
records; 359 rooms after 34 new QA/HTTP rooms. SQLite quick_check ok and zero
foreign-key violations. Healthy existing server reused; no reset/restart.

Boundaries: eight other Leader Skills, enemy-only mixed BG gather response,
expansion roster/green-card/optional-module combinations remain unfinished.
Winning traitor caller discard remains a documented card-specific inference.
No mode or publication gates opened.

Efficiency measure: aggregate goal counter 67321978 -> 68710948 (1388970),
including context and coordination; not billing tokens or a savings claim.
One skill's three connected effects, selective implementation/research/review,
one interrupted lint attempt followed by the required complete verification.
This commit is contained in:
Quintine committed 2026-09-13 18:16:36 +10:00
1 parent 6e6fecc9d4
commit 5082c81353
22 files changed
+2473 -93

No files matched your search

+14 -1
View File
@@ -15,6 +15,7 @@ import {
MOBILE_STRONGHOLD,
} from './board';
import { presenceAt } from './force-presence';
import { planetologistLeader } from './planetologist-movement';
import { validateAmbassadors } from './ecaz-ambassadors';
import {
homeworldMobileStrongholdMovementBlock,
@@ -115,7 +116,7 @@ function movementDeclaration(
Array.isArray(entry) &&
entry.length === 2 &&
sectorKey(g, entry[0]) &&
splitLocation(entry[0]).territory === move.origin &&
(move.origins ?? [move.origin]).includes(splitLocation(entry[0]).territory) &&
integer(entry[1]) &&
entry[1] > 0,
) &&
@@ -131,6 +132,18 @@ function movementDeclaration(
move.total,
'The canceled movement has invalid declared physical groups.',
);
if (move.planetologist || move.origins) {
requireContext(move.planetologist &&
move.planetologist.leader === planetologistLeader(g, owner.id) &&
!move.noField && !move.ornithopterEvent && !move.discoveryFlight &&
(move.planetologist.mode === 'range'
? move.origins === undefined
: move.planetologist.mode === 'gather' && Array.isArray(move.origins) &&
move.origins.length === 2 && new Set(move.origins).size === 2 &&
move.origins[0] === move.origin &&
JSON.stringify([...new Set(move.group.map(([key]) => splitLocation(key).territory))]) === JSON.stringify(move.origins)),
'The canceled Planetologist movement lost its skilled leader or exact origins.');
}
if (move.noField)
requireContext(
record(move.noField) &&