Repair inherited stale rule guards and two minimal-legal bot gaps

This commit is contained in:
Quintine committed 2026-10-09 01:49:39 +11:00
1 parent b892967eb3
commit 5e2a320512
15 files changed
+466 -93

No files matched your search

+23 -14
View File
@@ -187,20 +187,29 @@ to the already-implemented 7 October ordinary-lot contract.
**Stale-guard test sweep and one bot correctness fix.** Full offline runs
(`npm test`) were compared against the pre-session revision `4ed6beb` to
separate inherited debt from new regressions. Five superseded guard-pin tests
now assert the shipped contracts (Basic/Advanced mixed No-Field admission,
allied reserve arrival, combined-Occupy rejection message, the resolved
exhausted-cache cancellation), three reference wording-pin tests were deleted in
favour of the existing structural five-facet/evidence check, and the stale
Tleilaxu negotiated-revival guards and Duke-Tanks/shipment-integrity cases were
updated to real native outcomes. One genuine bot defect was fixed: a bot kept
proposing `acceptLeaderRevival` for a request whose leader was no longer dead
and captured (it now requires the leader to still be revivable and otherwise
cancels the unhonourable request), which removed 22 rejected actions from the
combined-expansion CLI sample. Twenty offline failures remain and all are
present at `4ed6beb` (odd-force Ecaz Occupy/high-threshold guards, several
alliance-entry and cache-cancel boundary cases, and two intermittently failing
Moritani skill-runtime tests measured at the same 3/30 rate on both revisions).
separate inherited debt from new regressions. Superseded guard pins now assert
the shipped contracts: Basic/Advanced mixed No-Field admission, allied reserve
arrival and its departure obligation, the combined-Occupy rejection message, the
resolved exhausted-cache cancellation, the authorized odd-force Basic Ecaz
Occupy arithmetic (`ceil(E/2)` provisional), Advanced Fremen/Ecaz Habbanya
cooccupation, both structured Truthtrance promise answers, and the two-entry
Ecaz alliance acceptance chronicle. Three reference wording-pin tests were
deleted in favour of the existing structural five-facet/evidence check, and the
Tleilaxu negotiated-revival, Duke-Tanks and pending-shipment cases were updated
to real native outcomes. Two genuine bot defects were fixed: a bot kept
proposing `acceptLeaderRevival` for a request whose leader was no longer a dead
uncaptured disc (it now requires the leader to still be revivable and otherwise
cancels the request, removing 22 rejected actions from the combined-expansion
CLI sample), and a concealed marker with a physical companion alongside now
reveals before that companion moves, in both modes. A repeated-Karama
cancellation of an already-canceled compulsory cache lot remains an explicit
open boundary recorded in the decision index. Two intermittently failing
Moritani skill-runtime tests were measured at the same 3/30 rate on both
revisions, so they are pre-existing nondeterminism rather than a regression; the
same holds for `tests/ecaz-occupy-options.test.ts`, whose Easy Occupy plan
candidate is occasionally absent (2/20 failing runs at `4ed6beb` versus 3/20
now), and for the paired Moritani skill-runtime tests. Those intermittent
failures are pre-existing prototype/AI gaps and are not new regressions.
**7 October 2026 — five pending rulings resolved by the user.** The user
answered five recorded questions; each is now recorded in
+1
View File
@@ -476,6 +476,7 @@ These are unresolved in the cited records. Do not infer an answer from elapsed t
| Leader Skills edge cases | Capture/replacement eligibility, Banker escrow custody, Smuggler modifier/allocation boundaries, Mentat empty-hand fallback, late/mirror/numeric Diplomat defenses and simultaneous optional timing remain source gaps. Printed alternate/hybrid defense roles now have a connected, explicitly interpreted copy path. The bounded Diplomat retreat prototype chooses printed/copied strength and surviving-loser retreat before casualties; this is not an official priority clarification. | [Material boundaries and retreat](LEADER_SKILLS_RULES.md#bounded-diplomat-retreat-interpretation), [Defense limits](DIPLOMAT_DEFENSE.md#evidence-and-remaining-scope) |
| Smuggler collection strength | A fresh primary-source check found no modifier ruling. The user was asked whether to keep affected combinations gated, use printed/copied disc value, or include leader bonuses with Stunner zero. No answer is assumed. The reveal-bound deferred receipt is supported as an explicit timing inference; unmodified lower collection is now [prototyped](SMUGGLER_BATTLE.md); modified strength, multiple positive piles and combined modules remain gated. | [Smuggler follow-up](LEADER_SKILLS_RULES.md#20-september-smuggler-follow-up) |
| Ordinary Guild cancellation | Unaffordable repricing, replacement/retry/decline, consumed opportunity, contributor adjustment and ordering with special shipment-stop. The affordability question was already sent. | [Material timing](GUILD_RATE_KARAMA_RULES.md#material-unresolved-timing) |
| Repeat Karama on a canceled compulsory cache lot | After one Karama cancels the compulsory Richese cache auction and restores the ordinary pool, the engine currently still accepts a second Karama against the resumed window and re-derives the ordinary count from the frozen pre-cache field. Whether a repeat cancellation should be refused is not settled; the invariant that a canceled lot never restores more than its frozen pre-cache count does hold. | [Richese auction source](RICHESE_AUCTION_RULES.md), [exhausted-cache runtime](IMPLEMENTATION_STATUS.md) |
| Base special Karama | Unfunded auction recovery, stopped-shipment settlement and Atreides full-plan commitment order remain provisional. Native full-plan/Voice/Prescience/Truthtrance/Ghola interactions now have genuine-setup focused evidence, but the source audit does not settle the special offer/deadline or target-first interpretation. | [Explicit base interpretations](BASE_ADVANCED_READINESS_20260907.md#explicit-unresolved-base-interpretations), [full-plan interaction audit](ATREIDES_FULL_PLAN_TIMING.md) |
| Occupied Homeworlds | The publisher question about retention after departure, replacement or contest, unique-power composition and shared income remains open; the first-occupier/current-occupier question was already sent. The content-first Basic benefit selector now uses the visibly provisional current-sole policy above (Tupile excepted), which is an implementation choice, not an answer to that question. | [Occupation questions](HOMEWORLD_OCCUPATION_RULES.md#questions-the-retrieved-sources-do-not-settle), [lifecycle audit](HOMEWORLD_OCCUPATION_LIFECYCLE_AUDIT.md), [Basic policy](HOMEWORLD_OCCUPATION_RULES.md#basic-current-sole-benefit-policy--9-october-2026) |
| Nexus responses and composition | Betrayal private-response timing, partial revival/payment choices, Emperor fewer-than-five, fresh advisor/storm cases, Duke restoration and remaining faction-specific combinations. Tleilaxu Secret Ally force accounting, leader slot/eligibility and force-only use remain unresolved after requested publisher/designer source searches; do not infer answers from native Tleilaxu revival or Ghola. | [Common boundaries](NEXUS_CARD_RULES.md#remaining-source-questions-and-release-boundaries), [Tleilaxu source search](NEXUS_TLEILAXU_RULES.md#source-search-follow-up) and individual faction source/runtime documents |