Add repeatable verification and establish fresh save checkpoint
Consolidate current readiness and existing rule decisions, preserve selective subagents and automatic verified Git pushes, and record the efficiency pilot. Add source-bound compact checks, private saved-game snapshots/online backups, and bounded HTTP seat-restoration checks with 15 meaningful regressions. At the user's explicit request, archive and clear 3,644 old local rooms and related records while retaining schema/migrations; preserve future games from a fresh empty baseline. Private backups and credentials are outside Git. Validation: npm run check passes types, lint and all 4,177 offline tests. Full report: 20260913-efficiency-check-3, 130.147 seconds; source fingerprint 344ce1d44475b0cd4ff10a915f28331cb4e2fcacbc7595636fbaa645c0568f64. Two earlier broad attempts stopped at new type/lint errors before tests; both were fixed. Independent review found cancellation falsely passing; SIGINT/SIGTERM regressions and review confirm the fix. Documentation links, example test selection, private backup integrity and empty baseline verified. No app/build/dependency/HTTP implementation changed; no production build, HTTP suite, browser acceptance or AI calibration claimed for this checkpoint. The full game goal and existing release gates remain unfinished.
This commit is contained in:
Quintine committed
1 parent
06d0a66fc5
commit
6e26ba5daa
17 files changed
+1242
-2
No files matched your search
@@ -0,0 +1,208 @@
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { execFileSync, spawnSync } from 'node:child_process';
|
||||
import {
|
||||
mkdtempSync,
|
||||
mkdirSync,
|
||||
writeFileSync,
|
||||
readFileSync,
|
||||
rmSync,
|
||||
symlinkSync,
|
||||
statSync,
|
||||
existsSync,
|
||||
} from 'node:fs';
|
||||
import { tmpdir } from 'node:os';
|
||||
import { join } from 'node:path';
|
||||
import {
|
||||
privateOutputDirectory,
|
||||
runVerification,
|
||||
sourceSnapshot,
|
||||
} from '../tools/verification';
|
||||
|
||||
void test('focused wrapper cannot turn a filename into a list-only or test-skipping option', (t) => {
|
||||
const { root, area } = fixture(t),
|
||||
out = join(area, 'run');
|
||||
const result = spawnSync(
|
||||
process.execPath,
|
||||
[
|
||||
'--import',
|
||||
import.meta.resolve('tsx'),
|
||||
new URL('../tools/verify.ts', import.meta.url).pathname,
|
||||
'--out',
|
||||
out,
|
||||
'focused',
|
||||
'--focus=--list',
|
||||
],
|
||||
{ cwd: root, encoding: 'utf8', timeout: 15000 },
|
||||
);
|
||||
assert.equal(result.status, 1);
|
||||
assert.equal(existsSync(out), false);
|
||||
});
|
||||
|
||||
function fixture(t: test.TestContext) {
|
||||
const area = mkdtempSync(join(tmpdir(), 'dune-verification-'));
|
||||
t.after(() => rmSync(area, { recursive: true, force: true }));
|
||||
const root = join(area, 'repo');
|
||||
mkdirSync(root);
|
||||
const git = (...args: string[]) =>
|
||||
execFileSync('git', args, { cwd: root, stdio: 'pipe' });
|
||||
git('init', '-q');
|
||||
writeFileSync(join(root, '.gitignore'), 'private.txt\n');
|
||||
writeFileSync(join(root, 'source.txt'), 'original');
|
||||
git('add', '.');
|
||||
git(
|
||||
'-c',
|
||||
'user.name=Verification',
|
||||
'-c',
|
||||
'user.email=verification@example.invalid',
|
||||
'commit',
|
||||
'-qm',
|
||||
'fixture',
|
||||
);
|
||||
return { area, root };
|
||||
}
|
||||
|
||||
void test('interrupted checks fail even when a child handles the signal with exit zero', (t) => {
|
||||
const { root, area } = fixture(t);
|
||||
for (const [signal, exitCode] of [
|
||||
['SIGINT', 130],
|
||||
['SIGTERM', 143],
|
||||
] as const) {
|
||||
const out = join(area, signal),
|
||||
script = join(area, `${signal}.mts`);
|
||||
const steps = [
|
||||
{
|
||||
name: 'interrupted',
|
||||
command: process.execPath,
|
||||
args: [
|
||||
'-e',
|
||||
`process.on('${signal}',()=>process.exit(0));process.kill(process.ppid,'${signal}');setInterval(()=>{},1000);`,
|
||||
],
|
||||
},
|
||||
{ name: 'must-not-run', command: process.execPath, args: ['-e', ''] },
|
||||
];
|
||||
writeFileSync(
|
||||
script,
|
||||
`import { runVerification } from ${JSON.stringify(new URL('../tools/verification.ts', import.meta.url).href)};\nawait runVerification(${JSON.stringify(root)}, ${JSON.stringify(out)}, ${JSON.stringify(steps)});\n`,
|
||||
);
|
||||
execFileSync(
|
||||
process.execPath,
|
||||
['--import', import.meta.resolve('tsx'), script],
|
||||
{ cwd: root, stdio: 'pipe', timeout: 15000 },
|
||||
);
|
||||
const report = JSON.parse(readFileSync(join(out, 'report.json'), 'utf8'));
|
||||
assert.equal(report.status, 'failed');
|
||||
assert.equal(report.steps.length, 1);
|
||||
assert.equal(report.steps[0].exitCode, exitCode);
|
||||
}
|
||||
});
|
||||
|
||||
void test('fingerprints include untracked source and ignore private local material', (t) => {
|
||||
const { root } = fixture(t),
|
||||
before = sourceSnapshot(root);
|
||||
writeFileSync(join(root, 'private.txt'), 'never include this');
|
||||
assert.deepEqual(sourceSnapshot(root), before);
|
||||
writeFileSync(join(root, 'new.ts'), 'new source');
|
||||
assert.notEqual(sourceSnapshot(root).tree, before.tree);
|
||||
rmSync(join(root, 'new.ts'));
|
||||
rmSync(join(root, 'source.txt'));
|
||||
assert.notEqual(sourceSnapshot(root).tree, before.tree);
|
||||
});
|
||||
|
||||
void test('verification preserves real child failures, stops later work and stores private logs', async (t) => {
|
||||
const { root, area } = fixture(t),
|
||||
out = join(area, 'run');
|
||||
const result = await runVerification(root, out, [
|
||||
{
|
||||
name: 'first',
|
||||
command: process.execPath,
|
||||
args: ['-e', 'console.log("first complete")'],
|
||||
},
|
||||
{
|
||||
name: 'failure',
|
||||
command: process.execPath,
|
||||
args: ['-e', 'console.error("failure detail");process.exit(7)'],
|
||||
},
|
||||
{
|
||||
name: 'must-not-run',
|
||||
command: process.execPath,
|
||||
args: ['-e', 'process.exit(0)'],
|
||||
},
|
||||
]);
|
||||
assert.equal(result.status, 'failed');
|
||||
assert.deepEqual(
|
||||
result.steps.map((s) => s.exitCode),
|
||||
[0, 7],
|
||||
);
|
||||
assert.match(
|
||||
readFileSync(join(out, 'failure.log'), 'utf8'),
|
||||
/failure detail/,
|
||||
);
|
||||
assert.equal(
|
||||
JSON.parse(readFileSync(join(out, 'report.json'), 'utf8')).status,
|
||||
'failed',
|
||||
);
|
||||
assert.equal(statSync(out).mode & 0o777, 0o700);
|
||||
assert.equal(statSync(join(out, 'report.json')).mode & 0o777, 0o600);
|
||||
await assert.rejects(
|
||||
runVerification(root, out, [
|
||||
{ name: 'repeat', command: process.execPath, args: ['-e', ''] },
|
||||
]),
|
||||
);
|
||||
assert.match(
|
||||
readFileSync(join(out, 'failure.log'), 'utf8'),
|
||||
/failure detail/,
|
||||
);
|
||||
});
|
||||
|
||||
void test('green processes cannot certify source changed during verification', async (t) => {
|
||||
const { root, area } = fixture(t);
|
||||
const result = await runVerification(root, join(area, 'run'), [
|
||||
{
|
||||
name: 'edit',
|
||||
command: process.execPath,
|
||||
args: ['-e', 'require("node:fs").writeFileSync("source.txt", "changed")'],
|
||||
},
|
||||
]);
|
||||
assert.equal(result.steps[0].exitCode, 0);
|
||||
assert.equal(result.status, 'source-changed');
|
||||
assert.notEqual(result.before.tree, result.after?.tree);
|
||||
});
|
||||
|
||||
void test('unchanged successful checks pass and missing executables fail', async (t) => {
|
||||
const { root, area } = fixture(t);
|
||||
assert.equal(
|
||||
(
|
||||
await runVerification(root, join(area, 'good'), [
|
||||
{ name: 'ok', command: process.execPath, args: ['-e', ''] },
|
||||
])
|
||||
).status,
|
||||
'passed',
|
||||
);
|
||||
assert.equal(
|
||||
(
|
||||
await runVerification(root, join(area, 'bad'), [
|
||||
{ name: 'missing', command: join(area, 'missing-command'), args: [] },
|
||||
])
|
||||
).status,
|
||||
'failed',
|
||||
);
|
||||
});
|
||||
|
||||
void test('output refuses checkout paths, symlink redirects and existing results', (t) => {
|
||||
const { root, area } = fixture(t);
|
||||
assert.throws(
|
||||
() => privateOutputDirectory(root, join(root, 'results')),
|
||||
/outside/,
|
||||
);
|
||||
symlinkSync(root, join(area, 'redirect'), 'dir');
|
||||
assert.throws(
|
||||
() => privateOutputDirectory(root, join(area, 'redirect/results')),
|
||||
/outside/,
|
||||
);
|
||||
const out = join(area, 'out');
|
||||
privateOutputDirectory(root, out);
|
||||
writeFileSync(join(out, 'sentinel'), 'keep');
|
||||
assert.throws(() => privateOutputDirectory(root, out));
|
||||
assert.equal(readFileSync(join(out, 'sentinel'), 'utf8'), 'keep');
|
||||
});
|
||||
Reference in new issue
Block a user