Fix mixed-deck Nexus Betrayal continuations
Verify and publish checkpoint container / container (push) Canceled after 0s

This commit is contained in:
Quintine committed 2026-10-30 18:12:45 +11:00
1 parent 6204efb7e4
commit 7680e1ee69
15 files changed
+487 -46

No files matched your search

+55 -37
View File
@@ -1,5 +1,7 @@
import { baseDeck, leaders, type Card } from './cards';
import { leaders, treacheryDeck, type Card } from './cards';
import { FACTIONS } from './catalog';
import { ecazTreacheryCards } from './ecaz-cards';
import { richeseCards } from './richese-cards';
import {
nexusCardMode, validateNexusCards, validateNexusPlayers,
type NexusPlayer, type NexusState,
@@ -8,7 +10,7 @@ import { validateNexusTraitorSnapshot, type NexusTraitorSnapshot } from './nexus
import {
validateTraitorDeclaration, type TraitorDeclaration, type TraitorDeclarationContext,
} from './traitor-declarations';
import { traitorDeck } from './traitors';
import { CHEAP_HERO_TRAITOR, traitorDeck } from './traitors';
export type HarkonnenBetrayalAuthority = {
provider: string;
@@ -27,6 +29,8 @@ export type HarkonnenBetrayalContext = {
sequence: number;
/** Public selection; absence retains the original base33 census. */
ecazTreachery?: boolean;
/** Selected physical decks for a fresh Basic expansion game. */
expansions?: readonly string[];
players: readonly NexusPlayer[];
cards: NexusState;
physicalCards: readonly Card[];
@@ -79,11 +83,6 @@ export class HarkonnenBetrayalError extends Error {
}
}
const genesis = 'harkonnen-betrayal:0';
const classic: Readonly<Record<string, true>> = {
atreides: true, harkonnen: true, emperor: true, fremen: true, guild: true, beneGesserit: true,
};
const canonicalCards = new Map(baseDeck().map(card => [card.id, card]));
const independentCards = new Map<string, Card>(ecazTreacheryCards().map(card => [card.id, card]));
const declarationKeys = ['event', 'voter', 'beneficiary', 'target', 'leader', 'identity', 'signature'] as const;
const plain = (value: unknown): value is Record<string, unknown> =>
value !== null && typeof value === 'object' && !Array.isArray(value) &&
@@ -105,43 +104,54 @@ function members(value: unknown): value is readonly string[] {
const equal = (one: unknown, two: unknown): boolean => JSON.stringify(one) === JSON.stringify(two);
function validateRoster(players: readonly NexusPlayer[]): void {
validateNexusPlayers(players);
requireBetrayal(players.every(player => Object.hasOwn(classic, player.faction)) &&
requireBetrayal(players.every(player => FACTIONS.some(faction => faction.id === player.faction)) &&
players.filter(player => player.faction === 'harkonnen').length === 1,
'Harkonnen Betrayal requires native Harkonnen and two through six classic seats.');
'Harkonnen Betrayal requires native Harkonnen and registered faction seats.');
}
function roster(players: readonly NexusPlayer[]): NexusPlayer[] {
return players.map(({ id, faction, ally }) => ({ id, faction, ally: ally ?? null }));
}
function canonicalUniverse(players: readonly NexusPlayer[]): string[] {
return traitorDeck(players.map(player => ({ leaders: leaders(player.faction) })));
function selectedExpansions(value: unknown, players: readonly NexusPlayer[], advanced: boolean): string[] {
const expansions = value === undefined ? [] : value;
requireBetrayal(Array.isArray(expansions) && expansions.every(id => ['ix', 'choam', 'ecaz'].includes(id)) &&
new Set(expansions).size === expansions.length && (!advanced || expansions.length === 0) &&
players.every(player => {
const faction = FACTIONS.find(item => item.id === player.faction);
return !!faction && (faction.expansion === 'base' || expansions.includes(faction.expansion));
}), 'Harkonnen Betrayal requires registered Basic selected faction decks.');
return expansions;
}
function validateUniverse(universe: readonly string[], players: readonly NexusPlayer[]): void {
const expected = canonicalUniverse(players);
function validateUniverse(universe: readonly string[], players: readonly NexusPlayer[], expansions: readonly string[]): void {
const expected = traitorDeck(players.map(player => ({ leaders: leaders(player.faction) })), expansions.includes('ix'));
requireBetrayal(members(universe) && universe.length === expected.length &&
universe.every(identity => expected.includes(identity)),
'Harkonnen Betrayal needs the original complete canonical classic Traitor universe.');
'Harkonnen Betrayal needs the original complete canonical Traitor universe.');
}
function validatePhysical(cards: readonly Card[], independent = false): void {
const count = canonicalCards.size + (independent ? independentCards.size : 0);
requireBetrayal(Array.isArray(cards) && cards.length === count &&
new Set(cards.map(card => card?.id)).size === count && cards.every(card => {
function validatePhysical(cards: readonly Card[], independent: boolean, expansions: readonly string[], players: readonly NexusPlayer[]): void {
const expectedCards = [...treacheryDeck(expansions), ...(independent ? ecazTreacheryCards() : []),
...(players.some(player => player.faction === 'richese') ? richeseCards() : [])];
const canonicalCards = new Map(expectedCards.map(card => [card.id, card]));
requireBetrayal(Array.isArray(cards) && cards.length === expectedCards.length &&
new Set(cards.map(card => card?.id)).size === expectedCards.length && cards.every(card => {
if (!plain(card) || !text(card.id)) return false;
const expected = canonicalCards.get(card.id) ?? (independent ? independentCards.get(card.id) : undefined);
const expected = canonicalCards.get(card.id);
return !!expected && exact(card, ['id', 'name', 'kind',
...(expected.effect === undefined ? [] : ['effect'])]) && card.name === expected.name &&
card.kind === expected.kind && card.effect === expected.effect;
}), 'Harkonnen Betrayal requires complete unique canonical selected Treachery custody.');
}
function validateBattle(battle: Battle): void {
function validateBattle(battle: Battle, expansions: readonly string[]): void {
const heroes = expansions.includes('ix') ? treacheryDeck(expansions).filter(card => card.kind === 'hero').map(card => card.id) : [];
requireBetrayal(exact(battle, ['event', 'attacker', 'defender', 'plans', 'heroLeaderIds']) &&
text(battle.event) && text(battle.attacker) && text(battle.defender) &&
battle.attacker !== battle.defender && exact(battle.plans, [battle.attacker, battle.defender]) &&
Array.isArray(battle.heroLeaderIds) && battle.heroLeaderIds.length === 0 &&
Array.isArray(battle.heroLeaderIds) && battle.heroLeaderIds.length === heroes.length &&
new Set(battle.heroLeaderIds).size === heroes.length && battle.heroLeaderIds.every(id => heroes.includes(id)) &&
Object.values(battle.plans).every(plan => plain(plan) &&
exact(plan, ['leader', ...(Object.hasOwn(plan, 'kwisatz') ? ['kwisatz'] : [])]) &&
(plan.leader === null || text(plan.leader)) &&
(plan.kwisatz === undefined || typeof plan.kwisatz === 'boolean')),
'Harkonnen Betrayal requires original sealed classic battle plans, without Ix heroes.');
'Harkonnen Betrayal requires original sealed battle plans and selected physical heroes.');
}
function declarationContext(
battle: Battle, players: readonly NexusPlayer[], traitors?: NexusTraitorSnapshot,
@@ -171,9 +181,10 @@ function validateAuthority(
authority.nativeRequired.length === 0 && authority.nativePassed.length === 0 :
authority.nativeWindow === 'harkonnenTraitor',
'Harkonnen Betrayal cannot confuse personal calls with native allowed allied calls.');
requireBetrayal(players.some(player => leaders(player.faction).some(leader =>
leader.id === authority.declaration.leader)) && authority.declaration.identity === authority.declaration.leader,
'Harkonnen Betrayal requires the opposing canonical classic leader identity.');
requireBetrayal((players.some(player => leaders(player.faction).some(leader =>
leader.id === authority.declaration.leader)) && authority.declaration.identity === authority.declaration.leader) ||
(battle.heroLeaderIds.includes(authority.declaration.leader) && authority.declaration.identity === CHEAP_HERO_TRAITOR),
'Harkonnen Betrayal requires the opposing canonical leader or physical hero identity.');
}
export function harkonnenBetrayalResponders(cards: NexusState, players: readonly NexusPlayer[]): string[] {
validateRoster(players);
@@ -205,15 +216,16 @@ function validateContext(ctx: HarkonnenBetrayalContext): void {
(ctx.ecazTreachery === undefined || typeof ctx.ecazTreachery === 'boolean'),
'Harkonnen Betrayal requires its current Battle phase and independent cursor.');
validateRoster(ctx.players);
const expansions = selectedExpansions(ctx.expansions, ctx.players, ctx.advanced);
validateNexusCards(ctx.cards, ctx.players);
validatePhysical(ctx.physicalCards, ctx.ecazTreachery);
validateUniverse(ctx.universe, ctx.players);
validatePhysical(ctx.physicalCards, ctx.ecazTreachery === true, expansions, ctx.players);
validateUniverse(ctx.universe, ctx.players, expansions);
validateNexusTraitorSnapshot(ctx.traitors, ctx.universe);
requireBetrayal(ctx.traitors.players.length === ctx.players.length &&
ctx.players.every(player => ctx.traitors.players.some(seat =>
seat.id === player.id && seat.faction === player.faction)),
'Harkonnen Betrayal physical Traitor custody must match its original roster.');
validateBattle(ctx.battle);
validateBattle(ctx.battle, expansions);
}
function sourceAuthority(source: HarkonnenBetrayalSource): HarkonnenBetrayalAuthority {
return { provider: source.provider, declaration: source.declaration, nativeWindow: source.nativeWindow,
@@ -222,6 +234,7 @@ function sourceAuthority(source: HarkonnenBetrayalSource): HarkonnenBetrayalAuth
function inventory(ctx: HarkonnenBetrayalContext): string {
const census: unknown[] = [ctx.cards, ctx.traitors, ctx.physicalCards];
if (ctx.ecazTreachery) census.push(true);
if (ctx.expansions?.length) census.push({ expansions: [...ctx.expansions] });
return JSON.stringify(census);
}
function sourceSignature(source: HarkonnenBetrayalSource): string {
@@ -244,9 +257,6 @@ function validateSavedSource(value: unknown): asserts value is HarkonnenBetrayal
validateRoster(source.players);
requireBetrayal(source.players.every(player => exact(player, ['id', 'faction', 'ally'])),
'Harkonnen Betrayal history must retain only the original public seat roles.');
validateUniverse(source.universe, source.players);
validateBattle(source.battle);
validateAuthority(sourceAuthority(source), source.players, source.battle);
// This is the original census, not today's holdings. Returning or redrawing
// the declared card later cannot invalidate this historical declaration.
let stored: unknown;
@@ -255,13 +265,21 @@ function validateSavedSource(value: unknown): asserts value is HarkonnenBetrayal
} catch {
throw new HarkonnenBetrayalError('Harkonnen Betrayal lost its original physical census.');
}
requireBetrayal(Array.isArray(stored) && (stored.length === 3 || (stored.length === 4 && stored[3] === true)),
requireBetrayal(Array.isArray(stored) && stored.length >= 3 && stored.length <= 5,
'Harkonnen Betrayal lost its original physical census.');
type SavedInventory = [NexusState, NexusTraitorSnapshot, readonly Card[], true?];
const [cards, traitors, physicalCards, independent] = stored as SavedInventory;
const [cards, traitors, physicalCards] = stored as [NexusState, NexusTraitorSnapshot, readonly Card[]];
const independent = stored[3] === true;
const selected = stored[independent ? 4 : 3];
requireBetrayal(stored.length === 3 + Number(independent) + Number(selected !== undefined) &&
(selected === undefined || (exact(selected, ['expansions']) && Array.isArray(selected.expansions) && selected.expansions.length > 0)),
'Harkonnen Betrayal lost its selected physical inventory.');
const expansions = selectedExpansions(selected?.expansions, source.players, source.advanced);
validateUniverse(source.universe, source.players, expansions);
validateBattle(source.battle, expansions);
validateAuthority(sourceAuthority(source), source.players, source.battle);
validateNexusCards(cards, source.players);
validateNexusTraitorSnapshot(traitors, source.universe);
validatePhysical(physicalCards, independent);
validatePhysical(physicalCards, independent, expansions, source.players);
requireBetrayal(traitors.players.length === source.players.length &&
source.players.every(player => traitors.players.some(seat =>
seat.id === player.id && seat.faction === player.faction)) &&
@@ -345,7 +363,8 @@ function validateCursor(value: unknown): asserts value is HarkonnenBetrayalCurso
(head[2] === 'pass' ? head[3] === null : head[2] === 'use' && text(head[3])) &&
Array.isArray(event) && event.length === 9 && event[0] === 'nexusHarkonnenBetrayal' &&
whole(event[1]) && event[1] > 0 && event[2] === value.sequence - 1 && event.slice(3).every(text) &&
event[4] !== event[6] && event[5] !== event[6] && event[7] === event[8] &&
event[4] !== event[6] && event[5] !== event[6] && (event[7] === event[8] ||
(event[8] === CHEAP_HERO_TRAITOR && treacheryDeck(['ix']).some(card => card.kind === 'hero' && card.id === event[7]))) &&
value.signature === JSON.stringify(head) && head[1] === JSON.stringify(event),
'Harkonnen Betrayal has a forged or recursive cursor head.');
}
@@ -389,7 +408,6 @@ export function validateHarkonnenBetrayalHistory(
'Harkonnen Betrayal history has a malformed receipt.');
validateSavedSource(receipt.source);
if (universe !== undefined) {
validateUniverse(universe, receipt.source.players);
requireBetrayal(equal(universe, receipt.source.universe), 'Harkonnen Betrayal changed its original universe.');
}
const identities = receipt.source.players.map(({ id, faction }) => ({ id, faction }));