Resolve advisor conversion after battle losses before optional cleanup

Preserve committed casualties, payments and mandatory disposal when battle losses leave BG bystanders alone. Bind the public phase-six receipt to the original battle and resume its private winner/aftermath cursor once. Record provisional priority; explosions with no surviving advisors create no response. Repair stale Semuta fixtures to acknowledge the existing final battle window; a representative failure reproduces against unchanged base035be51. Production Semuta guards stay intact. Validation: 16 affected files264/264, types/lint/build, five native battle and GameTable SSR journeys, eight existing-profile response paths. Genuine44-action sources earn original cards/forces and actual Collection outcomes. Broader combinations and complete modes remain unfinished. Not deployed; no room/D1, reset or restart operation. Runtime fingerprint 665defe51a1f46a6b5992b6e1e4b034203f91e7101acf860eb549f5bf9865151; checkpoint prose/reference overlays are reviewed separately.
2026-10-24 20:37:09 +11:00
1 parent 035be51915
commit d83db397c0
@@ -1,5 +1,73 @@
 # Mandatory advisor conversions

+## Battle losses before optional cleanup — 24 October 2026
+
+**Prototyped / Partial.** Compose the supplied
+Advanced source's physical17 group-flip counter with physical28 E's mandatory
+conversion when alone. Ordinary battle losses can leave surviving bystanding
+advisors alone even when neither combatant keeps a force. Preserve the completed
+battle result, payments, deaths and actual casualty allocation. An explosion
+that destroys the advisors leaves no group to convert.
+
+The selected provisional priority is after actual casualties (including Suk
+Graduate's physical rescue), original skills/substitution and mandatory Treachery
+disposal, before optional winner-card cleanup and subsequent aftermath effects.
+This is a composition under the 14 October recommended-policy authority, not a newly retrieved publisher
+priority ruling. Resolving the occurrence before later reinforcement/replacement
+avoids silently losing an already-earned conversion opportunity.
+
+Capture immediate no-winner losses after the original battle closes, retaining
+the advisor stance through mandatory disposal. Winner casualties capture the
+group before skills and compulsory winner disposal; their original choices
+finish before the response opens. The public phase6 source selects only the
+original event, turn, territory, two combatants, winner and result, bound to the
+exact surviving BG group. Cleanup cards and the winner/aftermath cursor stay in
+the private parent, outside the response and Karama source selection.
+
+After the counter, consume that parent before resuming the exact winner or
+aftermath cursor once. Never call battle resolution or apply casualties again.
+Preventing conversion preserves losses/costs and the existing provisional
+continuously-alone hold; it neither restores armies nor skips original cleanup.
+The original standard Karama/Allow controls explain this boundary. Other
+withdrawals, special arrivals and matching-group conversions remain open scope.
+
+[Native battle fixture](../tests/fixture-advisor-battle-flip.ts) starts public
+Advanced BG/Atreides/Harkonnen with original base33. Original advisorSetup places
+the peaceful counter beside Atreides' ten Arrakeen forces. Actual movement leaves
+one Atreides there, then brings one Harkonnen counter from Carthag by city range.
+Original Thufir5/dial1/support1 and Shield defeat Iakin2/dial0, leaving neither
+army. A second original pre-deal Traitor permutation and actual private choice
+earn mutual calls; both armies die and Shield's mandatory disposal precedes the
+conversion. A third original Lasgun/Shield deal destroys the advisor too. No
+played force, phase, hand, wallet, Tanks, stance or receipt is installed.
+
+[Engine cases](../tests/advisor-battle-flip-engine.test.ts) exercise both response
+outcomes and exact original cleanup, prevention holds through Collection,
+public/private parent mismatch rejection, no-survivor explosion and existing
+profiles. Frozen **16 files264/264**, types/lint/build, five native battle/
+response/GameTable SSR journeys and eight existing-profile paths pass. Each
+original source takes44 actual actions. Both battle outcomes reach actual
+Collection with two BG city income when allowed, none when prevented; actual
+Lasgun/Shield kills the advisor and opens no conversion. Standard existing
+controls render; this is not a new callback/browser/mobile/deployed certificate.
+
+The first frozen223/264 feedback found41 old Semuta battle cases expecting
+physical disposal before the existing final battle acknowledgements. A
+representative failure reproduced against unchanged base035be51 in isolated
+source, without copying saved games. Four focused fixtures now acknowledge only
+the original final window; two remaining direct-test callers receive the same
+repair. Focused3/3 then2/2 and the final264/264 pass, preserving original card/
+force/continuation assertions and all production Semuta guards.
+
+Private reports, baseline comparison, rendered HTML and hashes:
+`/home/quintine/.local/share/dune/checkpoints/20261024-advisor-battle-flips/`.
+`frozen-integrated-3/report.json` binds fingerprint
+`665defe51a1f46a6b5992b6e1e4b034203f91e7101acf860eb549f5bf9865151`
+on base `035be5191510333951bb3be9692ecfe3a233eace`. Checkpoint prose/reference
+updates are reviewed and hashed separately after proof.
+Full Suk/Rihani/Caladan/Face Dance/Semuta combinations are not certified by these
+native base scenarios; wider interaction and final assurance work remains due.
+
 ## Trip to Gamont before Mentat victory — 24 October 2026

 **Prototyped / Partial.** Compose supplied physical29 B’s return of one other
@@ -16,6 +16,34 @@ open mode gates.


 ## Current checkpoint and work
+**Advisor conversion after battle losses — 24 October. Prototyped / Partial.**
+Actual battle losses can now leave surviving bystanding advisors in a sourced
+Karama conversion response. Preserve casualties, payments, deaths and mandatory
+card disposal. Original skill/substitution handling retains priority, then the
+counter precedes optional winner-card cleanup and later aftermath under an
+explicit provisional ordering. Public identity/outcome stays separate from the
+private winner/aftermath cursor; consume it before resuming once. Prevention
+retains the existing continuously-alone hold and changes actual Collection.
+[Source, native scenarios and limits](ADVISOR_AUTOMATIC_FLIPS.md#battle-losses-before-optional-cleanup--24-october-2026).
+
+Disjoint helper/native-fixture lanes, bounded continuation review and root
+integration pass **16 files264/264**, types/lint/build, five native battle/response/
+GameTable SSR journeys and eight legal existing-profile paths. Genuine44-action
+public BG/Atreides/Harkonnen sources earn the original advisor, last-counter
+battle and original Shield/Karama. Winner dial-all and mutual Traitors preserve
+both armies' actual losses; allowance earns BG two city income, prevention earns
+none. An actual Lasgun/Shield explosion destroys the advisor and creates no
+conversion. Feedback repairs stale Semuta fixtures that skipped existing final
+battle acknowledgements; the representative failure also reproduced against
+unchanged base035be51. No production Semuta guard is relaxed. Full skill,
+reinforcement/replacement/Semuta combinations and other producers remain open.
+No AI refinement, comprehensive/browser/deployed assurance or saved-room/D1/
+reset/restart/deployment operation.
+
+Next native conversion work includes other withdrawals, special arrivals and
+matching-group flips. Battle, ground, transport and Gamont proofs do not certify
+all causes or complete Advanced modes.
+
 **Advisor conversion after Trip to Gamont — 24 October. Prototyped / Partial.**
 Gamont now completes its original card use and return/revelation before the
 resulting mandatory advisor-conversion counter. Preventing conversion preserves
@@ -39,11 +67,6 @@ combinations and remaining mandatory producers stay open. No AI refinement,
 comprehensive/browser/deployed assurance or saved-room/D1/reset/restart/deployment
 operation.

-Next native conversion producers include casualties/aftermath, other withdrawals
-and special arrivals. Preserve the original aftermath and collection continuations
-before extending this counter; ground, transport and Gamont proofs do not certify
-all mandatory conversion causes.
-
 **Advisor conversion after committed Guild transport — 24 October. Prototyped / Partial.**
 Guild cross-shipment and reserve returns now retain the original paid transfer
 and shipment use before mandatory advisor-conversion prevention. An exact public
@@ -1,5 +1,50 @@
 # Dune implementation status

+## 24 October 2026 — Advisor conversion after committed battle losses
+
+Supplied Advanced physical17/28 E now compose at native battle loss boundaries.
+Capture surviving BG bystanders after actual losses, including immediate
+no-winner losses before mandatory disposal. Preserve original skills,
+substitution and compulsory winner disposal, then open conversion before optional
+winner-card cleanup and later aftermath. That priority is explicit provisional
+policy. An explosion destroying the advisors creates no occurrence.
+
+A strict phase6 source selects only original event/turn/territory/combatants/
+winner/result and the exact held group. Private cleanup cards and the winner/aftermath cursor, checked against its
+stored signature, never enter the public response or Karama source selection. Consume the parent before resuming its exact cursor once; no replayed
+resolution, casualties, payment or disposal. Prevented conversion keeps the
+existing provisional continuously-alone hold through Collection.
+
+Disjoint pure-helper/native-fixture lanes, read-only continuation review and
+root integration pass **16 files264/264**, types/lint/build, five actual native
+battle/response/GameTable SSR journeys and eight legal existing-profile paths.
+Genuine44-action public Advanced BG/Atreides/Harkonnen sources earn the original
+advisor, real nine-counter departure and one-counter city arrival, original
+Thufir/Iakin plans and Shield/Karama. Winner dial-all and mutual Traitors leave
+both armies gone. Allowance earns two BG city income; prevention earns none.
+The original Lasgun/Shield variant kills the advisor too. No played force,
+phase, hand, wallet, Tanks, stance, prevention or receipt is installed.
+
+Initial223/264 feedback found41 stale Semuta battle cases skipping the existing
+final outcome acknowledgements. A representative case also fails against the
+unchanged base. Four fixture repairs preserve original actions/assertions and
+stop at the actual fresh discard. Two remaining direct callers need the same
+acknowledgement; focused3/3 then2/2 and the final264/264 pass. Production Semuta
+availability/continuation guards stay intact. One initial new-test optional
+absence assertion was also corrected; its focused native case then passed.
+
+Private proof, baseline comparison and original-action HTML:
+`/home/quintine/.local/share/dune/checkpoints/20261024-advisor-battle-flips/`.
+Frozen `frozen-integrated-3/report.json` binds tree
+`665defe51a1f46a6b5992b6e1e4b034203f91e7101acf860eb549f5bf9865151`,
+2739 files on base `035be5191510333951bb3be9692ecfe3a233eace`.
+Prose/reference overlays are separately reviewed/hashed. Standard response
+controls render; no new callback/browser/mobile/deployed or complete-mode claim.
+Full Suk/Rihani/Caladan/Face Dance/Semuta combinations, other automatic producers,
+comprehensive assurance and full AI refinement remain due. No saved-room/D1,
+reset, restart or deployment operation.
+[Source and connected behavior](ADVISOR_AUTOMATIC_FLIPS.md#battle-losses-before-optional-cleanup--24-october-2026).
+
 ## 24 October 2026 — Gamont conversion before final victory

 Compose the physical17/28 E advisor counter with physical29 B’s Mentat return.
@@ -1,5 +1,20 @@
 # Rule decision index

+## Advisor conversion after battle losses — 24 October 2026
+
+Compose supplied Advanced physical17's group counter with physical28 E's alone
+conversion after actual battle losses. Preserve the completed result, payments,
+deaths, casualty choices and mandatory disposal. Under the 14 October policy,
+resolve this conversion after original skill/substitution handling and before
+optional winner-card cleanup and later aftermath;
+that priority is provisional, not an explicit combined publisher ruling.
+Immediate no-winner losses retain their occurrence through original disposal.
+The public phase6 receipt omits private cleanup cards/cursor; consume the parent
+before resuming that exact cursor once, without replaying resolution or losses.
+An explosion with no surviving advisors produces no conversion. Retain the
+existing provisional continuously-alone duration and unfinished producer scope.
+[Source and continuation contract](ADVISOR_AUTOMATIC_FLIPS.md#battle-losses-before-optional-cleanup--24-october-2026).
+
 ## Advisor conversion after Trip to Gamont — 24 October 2026

 Compose supplied physical29 B’s Mentat return with physical17’s group counter and