Compose the deferred Terror arrival and green the mixed E3 programmes

Queue a committed Terror entry whose arrival also opened its own
interaction — Guild income, a Bene Gesserit fighter Intrusion or advisor
choice, or Fremen storm protection — in the additive
Game.pendingArrivalReaction list, and open the oldest queued entry from
settleAutomaticContinuations once nothing is pending. Payment, force
transfer and the original movement never replay; a Terror entry already in
flight and every Ambassador combination still reject.

Both withdrawn mixed E3 programme pairs are green: Moritani 9/9 and Ecaz
14/14, stable across 20 consecutive full-file runs. Their recorded resume
constraints became real fixture repairs, and the two restored consumer
omissions were corrected against the engine rather than re-pinned.

Repair pre-existing failures inherited at 45e6084 against current engine
behavior: stale Discovery and module gates in the native skills, Ix and
expansion-faction prototypes, the advanced Moritani skill boundary, the
Richese Nexus betrayal sale-credit expectation, one incidental gate
message and one flaky Collection-readiness assertion that reproduced at
HEAD.

Offline suite 7,793/7,793 with typecheck and lint clean. No game, seat,
saved-state, deployment, public-start or played-save conversion changes.
This commit is contained in:
Quintine committed 2026-10-07 17:24:23 +11:00
1 parent 45e6084424
commit e05a205a47
30 files changed
+2467 -117

No files matched your search

+22 -3
View File
@@ -329,9 +329,28 @@ void test('unsupported simultaneous arrivals fail before consent is committed an
);
hold(g, 'e', 'Karama');
g = offer(g);
const before = structuredClone(g);
assert.throws(() => accept(g), /combined with another arrival/);
assert.deepEqual(g, before);
// The consent commits its real shipment; the committed Terror entry waits
// for the arrival's own reaction instead of failing the whole consent.
const committed = accept(g);
// The consent commits its shipment and opens the No-Field response instead of
// rejecting the whole consent because a Terror token shares the destination.
assert.equal(committed.response?.kind, 'richeseNoField');
assert.deepEqual(committed.players[1].forces, {}, 'No force moves before the response settles.');
conserve(committed);
// Once the response settles, the committed arrival still offers its Terror entry.
let arrived = committed;
for (let i = 0; arrived.response && i < 8; i++) {
const passer = arrived.players.find(p => {
const controls = viewGame(arrived, p.id).responseControls;
return controls && controls.cancelCards.length && !controls.hasPassed;
});
assert.ok(passer, 'The No-Field response keeps a legal passer.');
arrived = send(arrived, passer!.id, { type: 'passResponse' });
}
assert.ok((arrived.pendingArrivalReaction?.length ?? 0) > 0 ||
arrived.pendingTerrorEntry !== null || arrived.decision?.kind === 'moritaniTerror',
'The committed Terror entry is offered or waits behind the arrival reaction.');
conserve(arrived);
const automated = structuredClone(g);
automated.players[1].bot = 'Medium';
const declined = runBots(automated, 1);