Support multiparty public deals

components/public-deals.tsx

@@ -2,11 +2,21 @@
 
 import { useEffect, useRef, useState } from 'react';
 import { faction } from '@/game/catalog';
+import { publicDealAcceptVotes, publicDealParticipants } from '@/game/public-deals';
 import type { Action, GameView } from '@/game/engine';
 import { Button } from '@/components/ui/button';
 
 type Deal = GameView['deals'][number];
 
+/** Keep the legacy single-recipient wire packet when only one seat is chosen. */
+export function publicDealOfferAction(targets: readonly string[], terms: string): Action | null {
+  const text = terms.trim();
+  if (!targets.length || targets.length > 5 || new Set(targets).size !== targets.length || !text || text.length > 500) return null;
+  return targets.length === 1
+    ? { type: 'dealOffer', target: targets[0], terms: text }
+    : { type: 'dealOffer', targets: [...targets], terms: text };
+}
+
 /** The whole table can read an offer and its history; only its parties act. */
 export function PublicDealList({ game, act, disabled }: {
   game: GameView;
@@ -22,24 +32,33 @@ export function PublicDealList({ game, act, disabled }: {
   if (!deals.length) return <p>No public deals have been proposed.</p>;
   return <ol>
     {deals.map(deal => {
-      const party = game.me === deal.from || game.me === deal.to;
+      const participants = publicDealParticipants(deal);
+      const accepted = publicDealAcceptVotes(deal);
+      const party = participants.includes(game.me);
       const voted = deal.releaseVotes.includes(game.me);
-      const partner = game.me === deal.from ? deal.to : deal.from;
+      const recipient = party && game.me !== deal.from;
+      const seats = participants.map(id => game.players.find(player => player.id === id));
+      const eligible = seats.every((player, index) => player && seats.slice(index + 1).every(other =>
+        other && player.ally !== other.id && other.ally !== player.id));
       return <li key={deal.id}>
-        <p><strong>{name(deal.from)} → {name(deal.to)}</strong> · Turn {deal.turn} · {deal.status}</p>
+        <p><strong>{name(deal.from)} → {participants.filter(id => id !== deal.from).map(name).join(', ')}</strong> · Turn {deal.turn} · {deal.status}</p>
         <p>{deal.terms}</p>
-        {deal.status === 'active' && deal.releaseVotes.length > 0 && <p>
-          Release requested by {deal.releaseVotes.map(name).join(', ')}. Both parties must agree to release the deal.
+        {deal.status === 'offered' && <p>
+          Accepted by {accepted.map(name).join(', ')}. Waiting for {participants.filter(id => !accepted.includes(id)).map(name).join(', ')}.
         </p>}
-        {canAct && deal.status === 'offered' && deal.to === game.me && <div className="flex flex-wrap gap-2">
-          <Button type="button" disabled={disabled} onClick={() => act({ type: 'dealRespond', deal: deal.id, accept: true })}>Accept deal</Button>
+        {deal.status === 'offered' && !eligible && <p>Acceptance is unavailable while any participants are allied; the offer may still be declined or withdrawn.</p>}
+        {deal.status === 'active' && deal.releaseVotes.length > 0 && <p>
+          Release requested by {deal.releaseVotes.map(name).join(', ')}. All parties must agree to release the deal.
+        </p>}
+        {canAct && deal.status === 'offered' && recipient && <div className="flex flex-wrap gap-2">
+          {!accepted.includes(game.me) && <Button type="button" disabled={disabled || !eligible} onClick={() => act({ type: 'dealRespond', deal: deal.id, accept: true })}>Accept deal</Button>}
           <Button type="button" variant="outline" disabled={disabled} onClick={() => act({ type: 'dealRespond', deal: deal.id, accept: false })}>Decline deal</Button>
         </div>}
         {canAct && deal.status === 'offered' && deal.from === game.me && <Button type="button" variant="outline" disabled={disabled}
           onClick={() => act({ type: 'dealWithdraw', deal: deal.id })}>Withdraw offer</Button>}
         {canAct && deal.status === 'active' && party && <Button type="button" variant="outline" disabled={disabled}
           onClick={() => act({ type: 'dealRelease', deal: deal.id, agree: !voted })}>
-          {voted ? 'Withdraw release request' : deal.releaseVotes.includes(partner) ? 'Agree to release deal' : 'Request release of deal'}
+          {voted ? 'Withdraw release request' : deal.releaseVotes.length > 0 ? 'Agree to release deal' : 'Request release of deal'}
         </Button>}
       </li>;
     })}
@@ -51,43 +70,65 @@ export function PublicDeals({ game, act, busy }: {
   act: (action: Action) => void;
   busy: boolean;
 }) {
-  const [target, setTarget] = useState('');
+  const [selected, setSelected] = useState<string[]>([]);
   const [terms, setTerms] = useState('');
-  const needsResponse = game.status === 'playing' && game.deals.some(deal =>
-    deal.status === 'offered' && deal.to === game.me ||
-    deal.status === 'active' && (deal.from === game.me || deal.to === game.me) &&
-      !deal.releaseVotes.includes(game.me) && deal.releaseVotes.length > 0);
+  const requests = game.status === 'playing' ? game.deals.flatMap(deal => {
+    const participant = publicDealParticipants(deal).includes(game.me);
+    if (deal.status === 'offered' && participant && deal.from !== game.me && !publicDealAcceptVotes(deal).includes(game.me))
+      return [['offer', deal.id]];
+    if (deal.status === 'active' && participant && !deal.releaseVotes.includes(game.me) && deal.releaseVotes.length > 0)
+      return [['release', deal.id, ...deal.releaseVotes]];
+    return [];
+  }) : [];
+  const needsResponse = requests.length > 0;
+  const requestKey = JSON.stringify(requests);
   const panel = useRef<HTMLDetailsElement>(null);
-  useEffect(() => { if (needsResponse && panel.current) panel.current.open = true; }, [needsResponse]);
+  useEffect(() => { if (requestKey !== '[]' && panel.current) panel.current.open = true; }, [requestKey]);
   if (game.status !== 'playing' && game.status !== 'finished') return null;
   const me = game.players.find(player => player.id === game.me);
-  const targets = game.players.filter(player => me && player.id !== me.id && !player.bot &&
-    player.id !== me.ally && player.ally !== me.id);
-  const recipient = targets.find(player => player.id === target);
+  const targets = game.players.filter(player => me && player.id !== me.id && !player.bot);
+  const selectedPlayers = targets.filter(player => selected.includes(player.id));
+  const allied = (a: typeof game.players[number], b: typeof game.players[number]) =>
+    a.ally === b.id || b.ally === a.id;
+  const legalSelection = !!me && selected.length > 0 && selected.length === selectedPlayers.length &&
+    selectedPlayers.every((player, index) => !allied(me, player) &&
+      selectedPlayers.slice(index + 1).every(other => !allied(player, other)));
+  const offer = legalSelection ? publicDealOfferAction(selected, terms) : null;
   const disabled = busy || !!game.roomControl?.paused || !!game.roomControl?.closed || !!me?.autopilot;
   const mayOffer = game.status === 'playing' && me && !me.bot;
   return <details ref={panel} className="notice public-deals-panel">
     <summary>Public deals{needsResponse ? ' · your response requested' : game.deals?.some(deal => deal.status === 'offered' || deal.status === 'active') ? ' · proposals or active deals' : ''}</summary>
-    <p>Deals are public. A recipient must accept an offer. Players must honor valid terms; an impossible part is void, and both parties can agree to release a deal. The game records the terms but cannot automatically enforce free-text promises or determine when they become impossible.</p>
+    <p>Deals are public. Every recipient must accept an offer. Players must honor valid terms; an impossible part is void, and all parties can agree to release a deal. The game records the terms but cannot automatically enforce free-text promises or determine when they become impossible.</p>
     <p>Do not trade cards, forces, leaders or faction powers, or make terms that contradict the rules or faction powers. A deal does not automatically transfer spice; use the Bribes control to make an eligible payment. <a href="/rules?topic=bribes#bribes">Bribe rules</a></p>
     {mayOffer && <form onSubmit={event => {
       event.preventDefault();
-      const text = terms.trim();
-      if (!disabled && recipient && text && text.length <= 500) act({ type: 'dealOffer', target: recipient.id, terms: text });
+      if (!disabled && offer) act(offer);
     }}>
-      <label>Deal recipient
-        <select value={recipient ? target : ''} onChange={event => setTarget(event.target.value)} disabled={disabled}>
-          <option value="">Choose a faction</option>
-          {targets.map(player => <option key={player.id} value={player.id}>{player.name} · {faction(player.faction).name}</option>)}
-        </select>
-      </label>
+      <fieldset>
+        <legend>Deal recipients</legend>
+        {targets.map(player => {
+          const checked = selected.includes(player.id);
+          const conflicts = !!me && (allied(me, player) || selectedPlayers.some(other => other.id !== player.id && allied(other, player)));
+          return <label key={player.id} className="checkbox-row">
+            <input type="checkbox" checked={checked} disabled={disabled || (!checked && conflicts)}
+              onChange={event => {
+                const nextChecked = event.target.checked;
+                setSelected(current => nextChecked
+                  ? current.includes(player.id) ? current : [...current, player.id] : current.filter(id => id !== player.id));
+              }} />
+            {player.name} · {faction(player.faction).name}{conflicts ? ' (allied with a selected party)' : ''}
+          </label>;
+        })}
+      </fieldset>
       <label>Public deal terms
         <textarea rows={3} maxLength={500} value={terms} onChange={event => setTerms(event.target.value)} disabled={disabled}
           placeholder="Describe the agreement for the table" />
       </label>
-      <p className="fine">Up to 500 characters. Offers are available to human non-allied players; AI negotiation is unfinished.</p>
-      <Button type="submit" disabled={disabled || !recipient || !terms.trim()}>Offer public deal</Button>
-      {targets.length === 0 && <p>No eligible human recipient is available.</p>}
+      <p className="fine">Up to 500 characters. Select human recipients who are not allied with each other or with you; AI negotiation is unfinished.</p>
+      <Button type="submit" disabled={disabled || !offer}>Offer public deal</Button>
+      {targets.length === 0 && <p>No human recipient is available.</p>}
+      {selected.length > 0 && !legalSelection && <p>Clear or change any recipient whose seat or alliance is no longer eligible.</p>}
+      {selected.length > 0 && <Button type="button" variant="outline" disabled={disabled} onClick={() => setSelected([])}>Clear recipients</Button>}
     </form>}
     <h3>Deal history</h3>
     <PublicDealList game={game} act={act} disabled={disabled} />