import assert from 'node:assert/strict'; import test from 'node:test'; import { advisorStanceAfterSettlement, AutomaticAdvisorFlipError, quoteAutomaticAdvisorFlips, validateAutomaticAdvisorFlip, type AdvisorSettlementContext, type AutomaticAdvisorFlipContext, type AutomaticAdvisorFlipSource, type AutomaticAdvisorTransport, type AutomaticAdvisorGamont, type AutomaticAdvisorBattle, type AutomaticAdvisorHomeworldTransport, type AutomaticAdvisorFaceDance, type AutomaticAdvisorStorm, type AutomaticAdvisorRelocation, } from '../game/advisor-automatic-flip'; import { MOBILE_LOCATION, MOBILE_STRONGHOLD } from '../game/board'; import { spiritualAdvisorArrival, type SpiritualAdvisorSource } from '../game/spiritual-advisor'; type GroundSource = Extract; type TransportSource = Extract; type GamontSource = Extract; type BattleSource = Extract; type HomeworldSource = Extract; type FaceDanceSource = Extract; type StormSource = Extract; type RelocationSource = Extract; type SpiritualArrivalSource = Extract; function context(): AutomaticAdvisorFlipContext { return { advanced: true, status: 'playing', turn: 4, phase: 5, players: [ { id: 'b', faction: 'beneGesserit', moved: 0, forces: { 'imperial_basin:9': 2, 'imperial_basin:10': 1, 'arrakeen:10': 1, 'carthag:11': 2, 'hagga_basin:12': 0 }, advisors: { imperial_basin: { lockedTurn: 4 }, arrakeen: {}, hagga_basin: {} }, }, { id: 'a', faction: 'atreides', moved: 1, forces: { 'carthag:11': 3 } }, { id: 'r', faction: 'richese', moved: 0, forces: {} }, ], }; } function held() { const ctx = context(); const choice = quoteAutomaticAdvisorFlips(ctx).find((entry) => entry.territory === 'imperial_basin')!; const source: GroundSource = { event: 'automatic-after-original-ground-move', owner: choice.player, territory: choice.territory, turn: ctx.turn, phase: ctx.phase, producer: 'groundMovement', mover: 'a', move: 1, forces: choice.forces, }; ctx.players[0].advisors = { ...ctx.players[0].advisors, imperial_basin: { ...ctx.players[0].advisors!.imperial_basin, aloneFlipHold: source.event }, }; return { ctx, source }; } void test('the phase-five quote finds whole physical advisor groups that became alone without using fresh locks as immunity', () => { const ctx = context(); const before = structuredClone(ctx); assert.deepEqual(quoteAutomaticAdvisorFlips(ctx), [ { player: 'b', territory: 'imperial_basin', forces: { 'imperial_basin:9': 2, 'imperial_basin:10': 1 } }, { player: 'b', territory: 'arrakeen', forces: { 'arrakeen:10': 1 } }, ]); assert.deepEqual(ctx, before); const quote = quoteAutomaticAdvisorFlips(ctx); quote[0].forces['imperial_basin:9'] = 99; assert.equal(ctx.players[0].forces['imperial_basin:9'], 2); assert.equal(quoteAutomaticAdvisorFlips(ctx)[0].forces['imperial_basin:9'], 2); }); void test('quotes exclude held, occupied and physically empty advisor groups while setup and other phases stay automatic', () => { const { ctx } = held(); ctx.players[1].forces = { ...ctx.players[1].forces, 'arrakeen:10': 1 }; assert.deepEqual(quoteAutomaticAdvisorFlips(ctx), []); for (const patch of [ { advanced: false }, { status: 'lobby' }, { status: 'setup', phase: 0 }, { phase: 2 }, { phase: 7 }, ]) { assert.deepEqual(quoteAutomaticAdvisorFlips({ ...context(), ...patch }), []); } const setup = context(); setup.phase = 0; assert.equal(advisorStanceAfterSettlement(setup, 'b', 'imperial_basin'), undefined); assert.equal(advisorStanceAfterSettlement(setup, 'b', 'hagga_basin'), undefined); }); void test('settlement uses only advanced and players, retains a held occurrence and clears that hold when another faction returns', () => { const { ctx, source } = held(); const board: AdvisorSettlementContext = { advanced: ctx.advanced, players: ctx.players }; const original = structuredClone(ctx); const stance = advisorStanceAfterSettlement(board, ctx.players[0], 'imperial_basin'); assert.deepEqual(stance, { lockedTurn: 4, aloneFlipHold: source.event }); assert.notEqual(stance, ctx.players[0].advisors!.imperial_basin); assert.equal(advisorStanceAfterSettlement(board, 'b', 'arrakeen'), undefined); assert.deepEqual(ctx, original); ctx.players[1].forces = { ...ctx.players[1].forces, 'imperial_basin:11': 1 }; assert.deepEqual(advisorStanceAfterSettlement(board, 'b', 'imperial_basin'), { lockedTurn: 4 }); assert.equal(ctx.players[0].advisors!.imperial_basin.aloneFlipHold, source.event); const basic = { ...board, advanced: false }; assert.deepEqual(advisorStanceAfterSettlement(basic, 'b', 'imperial_basin'), { lockedTurn: 4, aloneFlipHold: source.event }); }); void test('a continuous alone hold survives later phases and turns, while emptiness and a newly moved group do not inherit it', () => { const { ctx, source } = held(); ctx.phase = 7; ctx.turn++; assert.deepEqual(advisorStanceAfterSettlement(ctx, 'b', 'imperial_basin'), { lockedTurn: 4, aloneFlipHold: source.event }); ctx.phase = 5; assert.equal(quoteAutomaticAdvisorFlips(ctx).some((entry) => entry.territory === 'imperial_basin'), false); ctx.players[0].forces = { 'hagga_basin:12': 3 }; ctx.players[0].advisors = { ...ctx.players[0].advisors, hagga_basin: { lockedTurn: 4 } }; assert.equal(advisorStanceAfterSettlement(ctx, 'b', 'imperial_basin'), undefined); assert.equal(advisorStanceAfterSettlement(ctx, 'b', 'hagga_basin'), undefined); assert.deepEqual(quoteAutomaticAdvisorFlips(ctx), [ { player: 'b', territory: 'hagga_basin', forces: { 'hagga_basin:12': 3 } }, ]); }); void test('a concealed No-Field supplies public occupation without exposing its physical identity or printed value', () => { const { ctx } = held(); ctx.players[2].noField = { deployed: { location: { territory: 'imperial_basin', sector: 9 } } }; Object.defineProperty(ctx.players[2].noField, 'tokens', { get() { throw new Error('Automatic conversion read No-Field inventory'); }, }); Object.defineProperty(ctx.players[2].noField.deployed, 'value', { get() { throw new Error('Automatic conversion read No-Field value'); }, }); assert.deepEqual(advisorStanceAfterSettlement(ctx, 'b', 'imperial_basin'), { lockedTurn: 4 }); assert.equal(quoteAutomaticAdvisorFlips(ctx).some((entry) => entry.territory === 'imperial_basin'), false); }); void test('the response validates its original held event and exact physical group regardless of map insertion order', () => { const { ctx, source } = held(); const before = structuredClone({ ctx, source }); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, { ...source, forces: { 'imperial_basin:10': 1, 'imperial_basin:9': 2 }, })); assert.deepEqual({ ctx, source }, before); delete ctx.players[0].advisors; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); }); void test('changed window, owner, occurrence, group, occupation and movement sources throw the named rule error', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: GroundSource) => void)[] = [ (ctx) => { ctx.advanced = false; }, (ctx) => { ctx.status = 'lobby'; }, (ctx) => { ctx.phase = 4; }, (ctx) => { ctx.turn++; }, (_ctx, source) => { source.phase = 4; }, (_ctx, source) => { source.owner = 'a'; }, (_ctx, source) => { source.owner = 'missing'; }, (_ctx, source) => { source.territory = 'arrakeen'; }, (_ctx, source) => { source.event = 'other-occurrence'; }, (ctx) => { ctx.players[0].advisors = { imperial_basin: { aloneFlipHold: 'other-occurrence' } }; }, (ctx) => { ctx.players[0].forces = { 'imperial_basin:9': 3 }; }, (ctx) => { ctx.players[0].forces = {}; }, (ctx) => { ctx.players[1].forces = { 'imperial_basin:11': 1 }; }, (ctx) => { ctx.players[2].noField = { deployed: { location: { territory: 'imperial_basin', sector: 10 } } }; }, (_ctx, source) => { source.forces = {}; }, (_ctx, source) => { source.forces = { 'imperial_basin:9': 2 }; }, (_ctx, source) => { source.forces['imperial_basin:9'] = 1; }, (_ctx, source) => { source.forces['arrakeen:10'] = 1; }, (_ctx, source) => { source.forces['imperial_basin:9'] = 0; }, (_ctx, source) => { source.forces['imperial_basin:9'] = 1.5; }, (_ctx, source) => { source.move = 0; }, (_ctx, source) => { source.move = 2; }, (_ctx, source) => { source.mover = 'missing'; }, (ctx) => { ctx.players[1].moved = 2; }, (ctx) => { delete ctx.players[1].moved; }, (_ctx, source) => { (source as { producer: string }).producer = 'shipment'; }, ]; for (const change of changes) { const { ctx, source } = held(); change(ctx, source); const before = structuredClone({ ctx, source }); assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), (error: unknown) => error instanceof AutomaticAdvisorFlipError && error.name === 'AutomaticAdvisorFlipError'); assert.deepEqual({ ctx, source }, before); } const { ctx, source } = held(); for (const malformed of [null, [], { ...source, extra: true }, { ...source, forces: null }, { ...source, event: '' }]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('quotes, settlement and response matching do not inspect private cards, leaders or spice', () => { const { ctx, source } = held(); const before = ctx.players.map((player) => structuredClone({ forces: player.forces, advisors: player.advisors })); for (const player of ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers']) { Object.defineProperty(player, field, { get() { throw new Error(`Automatic advisor rule read ${player.id} private ${field}`); }, }); } } assert.equal(quoteAutomaticAdvisorFlips(ctx).some((entry) => entry.territory === 'arrakeen'), true); assert.deepEqual(advisorStanceAfterSettlement({ advanced: ctx.advanced, players: ctx.players }, 'b', 'imperial_basin'), { lockedTurn: 4, aloneFlipHold: source.event, }); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); assert.deepEqual(ctx.players.map((player) => ({ forces: player.forces, advisors: player.advisors })), before); }); function transported(to: 'carthag' | 'reserves' = 'carthag') { const { ctx, source: ground } = held(); const transport: AutomaticAdvisorTransport = { event: 'committed-native-guild-transport', player: 'a', origin: 'imperial_basin', to, sector: to === 'reserves' ? 0 : 11, amount: 3, elite: 0, group: { 'imperial_basin:9': 2, 'imperial_basin:10': 1 }, }; ctx.players[1].shipped = true; ctx.players[1].forces = to === 'reserves' ? {} : { 'carthag:11': 3 }; ctx.players[1].reserves = to === 'reserves' ? 3 : 0; const source: TransportSource = { event: 'automatic-after-original-guild-transport', owner: ground.owner, territory: ground.territory, turn: ground.turn, phase: ground.phase, forces: ground.forces, producer: 'guildTransport', transport, }; ctx.players[0].advisors = { ...ctx.players[0].advisors, imperial_basin: { lockedTurn: 4, aloneFlipHold: source.event }, }; return { ctx, source }; } void test('committed cross-transport and reserve return bind the same held advisor origin and physical deposit', () => { for (const destination of ['carthag', 'reserves'] as const) { const { ctx, source } = transported(destination); const before = structuredClone({ ctx, source }); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); assert.deepEqual({ ctx, source }, before); assert.deepEqual(Object.keys(source).sort(), ['event', 'forces', 'owner', 'phase', 'producer', 'territory', 'transport', 'turn']); assert.deepEqual(advisorStanceAfterSettlement({ advanced: true, players: ctx.players }, 'b', 'imperial_basin'), { lockedTurn: 4, aloneFlipHold: source.event, }); } }); void test('a native BG transported advisor arrival can bind its destination group without imposing a Guild-faction actor', () => { const { ctx, source } = transported(); source.transport = { event: 'committed-bg-cross-transport', player: 'b', origin: 'hagga_basin', to: 'imperial_basin', sector: 9, amount: 2, elite: 0, group: { 'hagga_basin:12': 2 }, }; ctx.players[0].shipped = true; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); source.transport.sector = 10; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); }); void test('transport metadata uses current board identities and rejects unplaced dynamic destinations', () => { const { ctx, source } = transported(); source.transport.to = MOBILE_STRONGHOLD; source.transport.sector = 0; ctx.players[1].forces = { [MOBILE_LOCATION]: 3 }; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); ctx.mobileStronghold = { location: 'imperial_basin:9' }; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); ctx.mobileStronghold.location = null; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); }); void test('changed transport metadata, selected group, native slot, deposit or response location rejects before settlement', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: TransportSource) => void)[] = [ (_ctx, source) => { source.transport.event = ''; }, (_ctx, source) => { source.transport.player = ''; }, (_ctx, source) => { source.transport.player = 'missing'; }, (_ctx, source) => { source.transport.origin = 'missing'; }, (_ctx, source) => { source.transport.to = 'missing'; }, (_ctx, source) => { source.transport.sector = -1; }, (_ctx, source) => { source.transport.sector = 11.5; }, (_ctx, source) => { source.transport.sector = 12; }, (_ctx, source) => { source.transport.amount = 0; }, (_ctx, source) => { source.transport.amount = 4; }, (_ctx, source) => { source.transport.elite = -1; }, (_ctx, source) => { source.transport.elite = 4; }, (_ctx, source) => { source.transport.elite = 1.5; }, (_ctx, source) => { source.transport.group = {}; }, (_ctx, source) => { source.transport.group = { 'imperial_basin:9': 3.5 }; }, (_ctx, source) => { source.transport.group = { 'imperial_basin:9': 3, 'imperial_basin:10': 0 }; }, (_ctx, source) => { source.transport.group = { 'carthag:11': 3 }; }, (_ctx, source) => { source.transport.group = { 'imperial_basin:8': 3 }; }, (_ctx, source) => { source.transport.group = { 'imperial_basin:9.0': 3 }; }, (_ctx, source) => { source.transport.origin = 'arrakeen'; source.transport.group = { 'arrakeen:10': 3 }; }, (ctx) => { ctx.players[1].shipped = false; }, (ctx) => { delete ctx.players[1].shipped; }, (ctx) => { ctx.players[1].forces = { 'carthag:11': 2 }; }, (ctx) => { ctx.players[1].forces = { 'carthag:10': 3 }; }, (ctx) => { ctx.players = [...ctx.players, { ...ctx.players[1] }]; }, (_ctx, source) => { source.forces = { 'imperial_basin:9': 3 }; }, ]; for (const change of changes) { const { ctx, source } = transported(); change(ctx, source); const before = structuredClone({ ctx, source }); assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); assert.deepEqual({ ctx, source }, before); } const { ctx, source } = transported('reserves'); ctx.players[1].reserves = 2; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); delete ctx.players[1].reserves; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); for (const malformed of [ { ...source, mover: 'a' }, { ...source, transport: null }, { ...source, transport: { ...source.transport, paid: 1 } }, { ...source, transport: { ...source.transport, group: null } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('old ground receipts keep their exact JSON shape and never require transport slot or reserve metadata', () => { const { ctx, source } = held(); for (const player of ctx.players) { for (const field of ['shipped', 'reserves']) { Object.defineProperty(player, field, { get() { throw new Error(`Ground source read transport-only ${field}`); }, }); } } const saved = JSON.parse(JSON.stringify(source)) as GroundSource; assert.deepEqual(Object.keys(saved).sort(), ['event', 'forces', 'move', 'mover', 'owner', 'phase', 'producer', 'territory', 'turn']); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, saved)); assert.throws(() => validateAutomaticAdvisorFlip(ctx, { ...saved, transport: {} } as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); }); void test('transport validation reads only public slot and physical deposit metadata, not wallets, cards or leaders', () => { for (const destination of ['carthag', 'reserves'] as const) { const { ctx, source } = transported(destination); for (const player of ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers']) { Object.defineProperty(player, field, { get() { throw new Error(`Transport advisor rule read ${player.id} private ${field}`); }, }); } } assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); } }); function gamont(returned = true, mentat = false) { const { ctx, source: ground } = held(); ctx.phase = 8; ctx.players[1].faction = 'choam'; ctx.players[2].reserves = returned ? 1 : 0; ctx.players[2].noField = { deployed: null }; const receipt: AutomaticAdvisorGamont = { event: 'completed-trip-to-gamont', player: 'a', target: 'r', location: 'imperial_basin:9', elite: 0, returned, mentat, }; const source: GamontSource = { event: 'automatic-after-completed-gamont', owner: ground.owner, territory: ground.territory, turn: ground.turn, phase: 8, forces: ground.forces, producer: 'gamont', gamont: receipt, }; ctx.players[0].advisors = { ...ctx.players[0].advisors, imperial_basin: { lockedTurn: 4, aloneFlipHold: source.event }, }; if (mentat) ctx.choamMentatPending = true; return { ctx, source }; } void test('phase-eight public groups can be quoted and Gamont validates with a real return or an empty No-Field reveal', () => { const quiet = context(); quiet.phase = 8; const before = structuredClone(quiet); assert.equal(quoteAutomaticAdvisorFlips(quiet).some((entry) => entry.territory === 'imperial_basin'), true); assert.deepEqual(quiet, before); for (const returned of [false, true]) { const { ctx, source } = gamont(returned); const original = structuredClone({ ctx, source }); assert.deepEqual(ctx.players[2].forces, {}); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); assert.deepEqual({ ctx, source }, original); assert.deepEqual(Object.keys(source).sort(), ['event', 'forces', 'gamont', 'owner', 'phase', 'producer', 'territory', 'turn']); assert.deepEqual(Object.keys(source.gamont).sort(), ['elite', 'event', 'location', 'mentat', 'player', 'returned', 'target']); } }); void test('only a final Gamont receipt requires the still-open native CHOAM Mentat flag', () => { const { ctx, source } = gamont(true, true); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); ctx.choamMentatPending = false; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); delete ctx.choamMentatPending; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); source.gamont.mentat = false; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); }); void test('Gamont metadata binds native CHOAM, the distinct target, current location, outcome and exact held group', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: GamontSource) => void)[] = [ (ctx) => { ctx.advanced = false; }, (ctx) => { ctx.status = 'lobby'; }, (ctx) => { ctx.turn++; }, (_ctx, source) => { source.gamont.event = ''; }, (_ctx, source) => { source.gamont.player = 'missing'; }, (ctx) => { ctx.players[1].faction = 'atreides'; }, (ctx) => { ctx.players = [...ctx.players, { ...ctx.players[1] }]; }, (_ctx, source) => { source.gamont.target = source.gamont.player; }, (_ctx, source) => { source.gamont.target = 'missing'; }, (ctx) => { ctx.players = [...ctx.players, { ...ctx.players[2] }]; }, (_ctx, source) => { source.gamont.location = 'missing:0'; }, (_ctx, source) => { source.gamont.location = 'imperial_basin:8'; }, (_ctx, source) => { source.gamont.location = 'imperial_basin:9.0'; }, (_ctx, source) => { source.gamont.location = 'arrakeen:10'; }, (_ctx, source) => { source.gamont.elite = -1; }, (_ctx, source) => { source.gamont.elite = 2; }, (_ctx, source) => { source.gamont.elite = 0.5; }, (ctx) => { ctx.players[2].reserves = 0; }, (ctx) => { delete ctx.players[2].reserves; }, (_ctx, source) => { source.forces = { 'imperial_basin:9': 3 }; }, (ctx) => { ctx.players[2].forces = { 'imperial_basin:10': 1 }; }, (ctx) => { ctx.players[0].advisors = { imperial_basin: { aloneFlipHold: 'another-event' } }; }, ]; for (const change of changes) { const { ctx, source } = gamont(); change(ctx, source); const before = structuredClone({ ctx, source }); assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); assert.deepEqual({ ctx, source }, before); } const { ctx, source } = gamont(); source.gamont.elite = 1; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); for (const malformed of [ { ...source, gamont: null }, { ...source, gamont: { ...source.gamont, returned: 'yes' } }, { ...source, gamont: { ...source.gamont, mentat: 1 } }, { ...source, gamont: { ...source.gamont, elite: '1' } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as unknown as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('private Gamont fuel and Nexus identifiers are rejected in either public source layer', () => { const { ctx, source } = gamont(); for (const malformed of [ { ...source, card: 'private-fuel-card' }, { ...source, fuel: 'private-fuel-card' }, { ...source, nexusEvent: 'private-nexus-event' }, { ...source, gamont: { ...source.gamont, card: 'private-fuel-card' } }, { ...source, gamont: { ...source.gamont, fuel: 'private-fuel-card' } }, { ...source, gamont: { ...source.gamont, nexusEvent: 'private-nexus-event' } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('producer phases stay distinct while the original ground and transport receipts remain accepted in phase five', () => { for (const original of [held(), transported()]) { const before = JSON.stringify(original.source); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.equal(JSON.stringify(original.source), before); original.ctx.phase = 8; assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); original.source.phase = 8; assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } const { ctx, source } = gamont(); ctx.phase = 5; source.phase = 5; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); }); void test('post-Gamont validation does not ask for prior availability, a remaining target counter or private fuel', () => { const { ctx, source } = gamont(false); for (const player of ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers', 'moved', 'shipped', 'gamontAvailable']) { Object.defineProperty(player, field, { get() { throw new Error(`Gamont advisor rule read ${player.id} ${field}`); }, }); } } for (const field of ['gamontAvailable', 'pendingAutomaticAdvisorGamont', 'choamMentatPending']) { Object.defineProperty(ctx, field, { get() { throw new Error(`Gamont advisor rule read private or prior ${field}`); }, }); } Object.defineProperty(ctx.players[2], 'reserves', { get() { throw new Error('An empty No-Field reveal has no returned counter to validate'); }, }); assert.deepEqual(ctx.players[2].forces, {}); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); }); function battleResult(result: AutomaticAdvisorBattle['result'] = 'normal') { const { ctx, source: ground } = held(); ctx.phase = 6; ctx.battle = null; ctx.players[1].forces = {}; ctx.players[2].forces = {}; const receipt: AutomaticAdvisorBattle = { event: 'original-resolved-battle', turn: ctx.turn, territory: 'imperial_basin', combatants: ['a', 'r'], winner: result === 'normal' || result === 'traitor' ? 'a' : null, result, }; ctx.lastBattleContext = { ...receipt, combatants: [...receipt.combatants] }; const source: BattleSource = { event: 'automatic-after-original-battle-losses', owner: ground.owner, territory: ground.territory, turn: ground.turn, phase: 6, forces: ground.forces, producer: 'battleLosses', battle: receipt, }; ctx.players[0].advisors = { ...ctx.players[0].advisors, imperial_basin: { lockedTurn: 4, aloneFlipHold: source.event }, }; return { ctx, source }; } void test('phase-six quotes and exact public resolved battle receipts retain a physically nonempty BG bystander group', () => { const quiet = context(); quiet.phase = 6; const original = structuredClone(quiet); assert.equal(quoteAutomaticAdvisorFlips(quiet).some((entry) => entry.territory === 'imperial_basin'), true); assert.deepEqual(quiet, original); for (const result of ['normal', 'traitor', 'mutualTraitors'] as const) { const { ctx, source } = battleResult(result); const before = structuredClone({ ctx, source }); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); assert.deepEqual({ ctx, source }, before); assert.deepEqual(Object.keys(source).sort(), ['battle', 'event', 'forces', 'owner', 'phase', 'producer', 'territory', 'turn']); assert.deepEqual(Object.keys(source.battle).sort(), ['combatants', 'event', 'result', 'territory', 'turn', 'winner']); } }); void test('a stale battle event, turn, winner, participant, location or active battle cannot settle the held source', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: BattleSource) => void)[] = [ (ctx) => { ctx.advanced = false; }, (ctx) => { ctx.status = 'lobby'; }, (ctx) => { ctx.turn++; }, (ctx) => { ctx.battle = {}; }, (ctx) => { ctx.lastBattleContext = null; }, (ctx) => { delete ctx.lastBattleContext; }, (ctx) => { ctx.lastBattleContext!.event = 'changed-battle'; }, (ctx) => { ctx.lastBattleContext!.turn++; }, (ctx) => { ctx.lastBattleContext!.territory = 'arrakeen'; }, (ctx) => { ctx.lastBattleContext!.winner = 'r'; }, (ctx) => { ctx.lastBattleContext!.result = 'traitor'; }, (_ctx, source) => { source.battle.event = 'stale-battle'; }, (_ctx, source) => { source.battle.turn++; }, (_ctx, source) => { source.battle.territory = 'arrakeen'; }, (_ctx, source) => { source.battle.territory = 'missing'; }, (_ctx, source) => { source.battle.combatants = ['a', 'a']; }, (_ctx, source) => { source.battle.combatants = ['a', 'missing']; }, (_ctx, source) => { source.battle.combatants.reverse(); }, (_ctx, source) => { source.battle.winner = null; }, (_ctx, source) => { source.battle.winner = 'b'; }, (_ctx, source) => { source.battle.result = 'mutualTraitors'; }, (_ctx, source) => { source.battle.result = 'explosion'; }, (ctx) => { ctx.players = [...ctx.players, { ...ctx.players[1] }]; }, (ctx) => { ctx.players[1].forces = { 'imperial_basin:9': 1 }; }, (_ctx, source) => { source.forces = { 'imperial_basin:9': 3 }; }, ]; for (const change of changes) { const { ctx, source } = battleResult(); change(ctx, source); const before = structuredClone({ ctx, source }); assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); assert.deepEqual({ ctx, source }, before); } const { ctx, source } = battleResult(); for (const malformed of [ { ...source, battle: null }, { ...source, battle: { ...source.battle, result: 'legacy' } }, { ...source, battle: { ...source.battle, winner: 1 } }, { ...source, battle: { ...source.battle, combatants: ['a'] } }, { ...source, battle: { ...source.battle, combatants: ['a', 'r', 'b'] } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as unknown as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('a BG combatant or an explosion with no remaining physical advisor group has no valid bystander conversion', () => { const combatant = battleResult(); combatant.source.battle.combatants = ['b', 'r']; combatant.source.battle.winner = 'r'; combatant.ctx.lastBattleContext = { ...combatant.source.battle, combatants: ['b', 'r'] }; assert.throws(() => validateAutomaticAdvisorFlip(combatant.ctx, combatant.source), AutomaticAdvisorFlipError); const exploded = battleResult('explosion'); assert.equal(exploded.source.battle.winner, null); for (const player of exploded.ctx.players) player.forces = {}; assert.deepEqual(quoteAutomaticAdvisorFlips(exploded.ctx), []); assert.throws(() => validateAutomaticAdvisorFlip(exploded.ctx, exploded.source), AutomaticAdvisorFlipError); }); void test('battle source and receipt layers reject private cards, skills, casualty choices and continuation payloads', () => { const { ctx, source } = battleResult(); for (const field of ['cards', 'skills', 'casualtyChoices', 'continuation']) { for (const malformed of [ { ...source, [field]: 'private-payload' }, { ...source, battle: { ...source.battle, [field]: 'private-payload' } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } } }); void test('phase-six battle conversion does not widen the old movement, transport or Gamont producer windows', () => { for (const original of [held(), transported(), gamont(false)]) { const before = JSON.stringify(original.source); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.equal(JSON.stringify(original.source), before); original.ctx.phase = 6; original.source.phase = 6; assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } for (const phase of [5, 8]) { const { ctx, source } = battleResult(); ctx.phase = phase; source.phase = phase; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); } }); void test('battle validation reads only its six public context fields and the current physical group', () => { const { ctx, source } = battleResult(); for (const player of ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers', 'moved', 'shipped', 'reserves']) { Object.defineProperty(player, field, { get() { throw new Error(`Battle advisor rule read ${player.id} private or unrelated ${field}`); }, }); } } for (const field of ['cardRoles', 'mandatoryDiscard', 'winnerDiscards', 'skills', 'casualtyChoices', 'continuation']) { Object.defineProperty(ctx.lastBattleContext, field, { enumerable: true, get() { throw new Error(`Battle advisor rule read private context ${field}`); }, }); } assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); ctx.battle = false; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); }); function homeworldTransport( kind: AutomaticAdvisorHomeworldTransport['kind'] = 'native', destination = 'homeworld:richese', ) { const { ctx, source: ground } = held(); ctx.homeworlds = { custody: { visitors: {}, salusa: null } }; ctx.players[1].faction = kind === 'native' ? 'guild' : 'atreides'; ctx.players[1].shipped = true; ctx.players[1].forces = destination.startsWith('homeworld:') ? {} : { [destination]: 3 }; if (kind === 'junction') ctx.players = [...ctx.players, { id: 'g', faction: 'guild', forces: {} }]; const transport: AutomaticAdvisorHomeworldTransport = { event: 'fresh-public-homeworld-transport-event', kind, player: 'a', origin: 'imperial_basin', destination, amount: 3, elite: 0, group: { 'imperial_basin:9': 2, 'imperial_basin:10': 1 }, }; const source: HomeworldSource = { event: 'automatic-after-original-homeworld-transport', owner: ground.owner, territory: ground.territory, turn: ground.turn, phase: 5, forces: ground.forces, producer: 'homeworldTransport', transport, }; ctx.players[0].advisors = { ...ctx.players[0].advisors, imperial_basin: { lockedTurn: 4, aloneFlipHold: source.event }, }; return { ctx, source }; } void test('native Guild and Junction Homeworld transports retain exact public source shapes and current native destinations', () => { for (const original of [ homeworldTransport(), homeworldTransport('native', 'homeworld:guild'), homeworldTransport('junction'), homeworldTransport('junction', 'carthag:11'), ]) { const before = structuredClone(original); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.deepEqual(original, before); assert.deepEqual(Object.keys(original.source).sort(), ['event', 'forces', 'owner', 'phase', 'producer', 'territory', 'transport', 'turn']); assert.deepEqual(Object.keys(original.source.transport).sort(), ['amount', 'destination', 'elite', 'event', 'group', 'kind', 'origin', 'player']); } const salusa = homeworldTransport('junction', 'homeworld:emperor:salusa'); assert.throws(() => validateAutomaticAdvisorFlip(salusa.ctx, salusa.source), AutomaticAdvisorFlipError); salusa.ctx.players = [...salusa.ctx.players, { id: 'e', faction: 'emperor', forces: {} }]; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(salusa.ctx, salusa.source)); }); void test('a Junction BG advisor arrival binds the actual destination group and deposited physical board counters', () => { const { ctx, source } = homeworldTransport('junction', 'imperial_basin:9'); ctx.players[1].forces = {}; ctx.players[0].shipped = true; source.transport.player = 'b'; source.transport.origin = 'hagga_basin'; source.transport.group = { 'hagga_basin:12': 2 }; source.transport.amount = 2; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); source.transport.destination = 'imperial_basin:10'; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); const departed = homeworldTransport('junction', 'carthag:11'); departed.ctx.players[1].forces = { 'carthag:11': 2 }; assert.throws(() => validateAutomaticAdvisorFlip(departed.ctx, departed.source), AutomaticAdvisorFlipError); }); void test('Homeworld transport rejects malformed metadata, missing native permissions, current locations and changed held groups', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: HomeworldSource) => void)[] = [ (_ctx, source) => { source.transport.event = ''; }, (_ctx, source) => { source.transport.player = 'missing'; }, (_ctx, source) => { source.transport.origin = 'missing'; }, (_ctx, source) => { source.transport.destination = 'homeworld:emperor'; }, (_ctx, source) => { source.transport.destination = 'reserves'; }, (_ctx, source) => { source.transport.destination = 'carthag:11'; }, (_ctx, source) => { source.transport.amount = 0; }, (_ctx, source) => { source.transport.amount = 2; }, (_ctx, source) => { source.transport.elite = -1; }, (_ctx, source) => { source.transport.elite = 4; }, (_ctx, source) => { source.transport.elite = 1.5; }, (_ctx, source) => { source.transport.group = {}; }, (_ctx, source) => { source.transport.group = { 'carthag:11': 3 }; }, (_ctx, source) => { source.transport.group = { 'imperial_basin:9': 3.5 }; }, (_ctx, source) => { source.transport.group = { 'imperial_basin:9': 3, 'imperial_basin:10': 0 }; }, (_ctx, source) => { source.transport.group = { 'imperial_basin:8': 3 }; }, (_ctx, source) => { source.transport.group = { 'imperial_basin:9.0': 3 }; }, (_ctx, source) => { source.transport.origin = 'hagga_basin'; source.transport.group = { 'hagga_basin:12': 3 }; }, (ctx) => { ctx.players[1].faction = 'atreides'; }, (ctx) => { ctx.players[1].shipped = false; }, (ctx) => { delete ctx.players[1].shipped; }, (ctx) => { ctx.players = [...ctx.players, { ...ctx.players[1] }]; }, (_ctx, source) => { source.forces = { 'imperial_basin:9': 3 }; }, ]; for (const change of changes) { const original = homeworldTransport(); change(original.ctx, original.source); const before = structuredClone(original); assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); assert.deepEqual(original, before); } const junction = homeworldTransport('junction', 'carthag:11'); junction.ctx.players = junction.ctx.players.filter((player) => player.faction !== 'guild'); assert.throws(() => validateAutomaticAdvisorFlip(junction.ctx, junction.source), AutomaticAdvisorFlipError); for (const destination of ['carthag', 'carthag:10', 'carthag:11.0', 'homeworld:emperor:salusa']) { const invalid = homeworldTransport('junction', destination); assert.throws(() => validateAutomaticAdvisorFlip(invalid.ctx, invalid.source), AutomaticAdvisorFlipError); } for (const homeworldState of [undefined, null, [], false, 'homeworlds', {}, { custody: null }, { custody: [] }]) { const original = homeworldTransport(); original.ctx.homeworlds = homeworldState; assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } }); void test('Homeworld source receipts reject private original events and stale producer payloads at both layers', () => { const { ctx, source } = homeworldTransport(); for (const field of ['homeworldShipmentEvent', 'card', 'nexusEvent', 'funds', 'permission']) { for (const malformed of [ { ...source, [field]: 'private-original-state' }, { ...source, transport: { ...source.transport, [field]: 'private-original-state' } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } } for (const malformed of [ { ...source, transport: null }, { ...source, transport: { ...source.transport, kind: 'guild' } }, { ...source, transport: { ...source.transport, group: null } }, { ...source, transport: transported().source.transport }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as unknown as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('Homeworld transport stays phase-five-only and leaves all earlier producer receipt shapes and windows unchanged', () => { for (const original of [held(), transported(), gamont(false), battleResult()]) { const before = JSON.stringify(original.source); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.equal(JSON.stringify(original.source), before); } for (const phase of [4, 6, 8]) { const { ctx, source } = homeworldTransport(); ctx.phase = phase; source.phase = phase; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); } }); void test('Homeworld source validation never reads original shipment events, private module players or pretransfer funding', () => { for (const original of [homeworldTransport(), homeworldTransport('junction', 'carthag:11')]) { const custody = {}; for (const field of ['visitors', 'salusa', 'players']) { Object.defineProperty(custody, field, { get() { throw new Error(`Advisor transport helper read delegated world custody ${field}`); }, }); } const homeworldState = { custody }; Object.defineProperty(homeworldState, 'players', { get() { throw new Error('Advisor transport helper read private Homeworld players'); }, }); original.ctx.homeworlds = homeworldState; for (const field of ['homeworldShipmentEvent', 'pendingHomeworldShipment', 'pendingAutomaticAdvisorHomeworldTransport']) { Object.defineProperty(original.ctx, field, { get() { throw new Error(`Advisor transport helper read private parent ${field}`); }, }); } for (const player of original.ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers', 'reserves', 'pledged', 'guildTransportPermission']) { Object.defineProperty(player, field, { get() { throw new Error(`Advisor transport helper read ${player.id} private funding or custody ${field}`); }, }); } } assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); } }); function faceDance(combatant = true, result: 'normal' | 'traitor' = 'normal') { const { ctx, source: ground } = held(); ctx.phase = 6; ctx.battle = null; ctx.players[0].forces = { 'imperial_basin:9': 2, 'imperial_basin:10': 1, 'arrakeen:10': 1 }; ctx.players[1].forces = {}; ctx.players[2].faction = 'tleilaxu'; ctx.players[2].forces = { 'carthag:11': 2 }; const battle: AutomaticAdvisorBattle = { event: 'original-face-dance-battle', turn: ctx.turn, territory: 'carthag', combatants: combatant ? ['b', 'a'] : ['a', 'r'], winner: 'a', result, }; const receipt: AutomaticAdvisorFaceDance = { event: 'completed-public-face-dance', battle, player: 'r', territory: 'carthag', sector: 11, sources: { 'imperial_basin:9': 1, reserves: 1 }, amount: 2, returned: { a: 2 }, }; ctx.lastBattleContext = { ...battle, combatants: [...battle.combatants] }; const source: FaceDanceSource = { event: 'automatic-after-remote-face-dance-source', owner: ground.owner, territory: ground.territory, turn: ground.turn, phase: 6, forces: ground.forces, producer: 'faceDance', faceDance: receipt, }; ctx.players[0].advisors = { ...ctx.players[0].advisors, imperial_basin: { lockedTurn: 4, aloneFlipHold: source.event }, }; return { ctx, source }; } void test('Face Dance remote sources accept a BG original combatant or bystander after a normal or traitor result', () => { for (const combatant of [false, true]) { for (const result of ['normal', 'traitor'] as const) { const original = faceDance(combatant, result); const before = structuredClone(original); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.deepEqual(original, before); assert.deepEqual(Object.keys(original.source).sort(), ['event', 'faceDance', 'forces', 'owner', 'phase', 'producer', 'territory', 'turn']); assert.deepEqual(Object.keys(original.source.faceDance).sort(), ['amount', 'battle', 'event', 'player', 'returned', 'sector', 'sources', 'territory']); } } }); void test('every positive board source can bind its own exact held group and returned Ecaz co-side counts may include Tleilaxu', () => { const { ctx, source } = faceDance(); source.faceDance.sources = { 'imperial_basin:9': 1, 'hagga_basin:12': 1 }; ctx.players[0].forces = { ...ctx.players[0].forces, 'hagga_basin:12': 1 }; const remote: FaceDanceSource = { ...source, event: 'automatic-after-second-remote-source', territory: 'hagga_basin', forces: { 'hagga_basin:12': 1 }, }; ctx.players[0].advisors = { ...ctx.players[0].advisors, hagga_basin: { aloneFlipHold: remote.event }, }; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, remote)); ctx.players[1].faction = 'ecaz'; source.faceDance.returned = { a: 1, r: 1 }; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, remote)); }); void test('zero replacement can leave advisors at the board target and a native World target delegates its new physical deposit', () => { const zero = faceDance(false); zero.source.territory = 'carthag'; zero.source.forces = { 'carthag:11': 2 }; zero.source.faceDance.amount = 0; zero.source.faceDance.sources = {}; zero.ctx.players[0].forces = { 'carthag:11': 2 }; zero.ctx.players[0].advisors = { carthag: { aloneFlipHold: zero.source.event } }; zero.ctx.players[2].forces = {}; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(zero.ctx, zero.source)); const world = faceDance(); world.source.faceDance.territory = 'homeworld:tleilaxu'; world.source.faceDance.sector = 0; world.source.faceDance.amount = 1; world.source.faceDance.sources = { 'imperial_basin:9': 1 }; world.source.faceDance.battle.territory = 'homeworld:tleilaxu'; world.ctx.lastBattleContext = { ...world.source.faceDance.battle, combatants: [...world.source.faceDance.battle.combatants], }; world.ctx.players[2].forces = {}; assert.throws(() => validateAutomaticAdvisorFlip(world.ctx, world.source), AutomaticAdvisorFlipError); world.ctx.homeworlds = { custody: {} }; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(world.ctx, world.source)); world.source.faceDance.sector = 1; assert.throws(() => validateAutomaticAdvisorFlip(world.ctx, world.source), AutomaticAdvisorFlipError); }); void test('Face Dance validates current public battle identity, actor, positive sources, returns, board deposit and held group', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: FaceDanceSource) => void)[] = [ (ctx) => { ctx.battle = {}; }, (ctx) => { ctx.lastBattleContext = null; }, (ctx) => { ctx.lastBattleContext!.event = 'stale'; }, (ctx) => { ctx.lastBattleContext!.combatants = ['a', 'b']; }, (_ctx, source) => { source.faceDance.event = ''; }, (_ctx, source) => { source.faceDance.battle.event = 'stale'; }, (_ctx, source) => { source.faceDance.battle.turn++; }, (_ctx, source) => { source.faceDance.battle.winner = null; }, (ctx, source) => { source.faceDance.battle.combatants = ['b', 'r']; source.faceDance.battle.winner = 'r'; ctx.lastBattleContext = { ...source.faceDance.battle, combatants: ['b', 'r'] }; }, (_ctx, source) => { source.faceDance.player = 'missing'; }, (ctx) => { ctx.players[2].faction = 'richese'; }, (ctx) => { ctx.players = [...ctx.players, { ...ctx.players[2] }]; }, (_ctx, source) => { source.faceDance.territory = 'arrakeen'; }, (_ctx, source) => { source.faceDance.sector = 10; }, (_ctx, source) => { source.faceDance.amount = -1; }, (_ctx, source) => { source.faceDance.amount = 3; }, (_ctx, source) => { source.faceDance.sources = { reserves: 2 }; }, (_ctx, source) => { source.faceDance.sources = { 'imperial_basin:8': 2 }; }, (_ctx, source) => { source.faceDance.sources = { 'imperial_basin:9.0': 2 }; }, (_ctx, source) => { source.faceDance.sources = { 'homeworld:tleilaxu:0': 2 }; }, (_ctx, source) => { source.faceDance.sources = { 'imperial_basin:9': 1, reserves: 1, 'hagga_basin:12': 0 }; }, (_ctx, source) => { source.faceDance.sources = { 'imperial_basin:9': 1.5, reserves: 0.5 }; }, (_ctx, source) => { source.faceDance.returned = { missing: 2 }; }, (_ctx, source) => { source.faceDance.returned = { a: 0 }; }, (_ctx, source) => { source.faceDance.returned = { a: 1.5 }; }, (ctx) => { ctx.players[2].forces = { 'carthag:11': 1 }; }, (_ctx, source) => { source.forces = { 'imperial_basin:9': 3 }; }, ]; for (const change of changes) { const original = faceDance(); change(original.ctx, original.source); const before = structuredClone(original); assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); assert.deepEqual(original, before); } for (const result of ['mutualTraitors', 'explosion'] as const) { const original = faceDance(); original.source.faceDance.battle.result = result; original.source.faceDance.battle.winner = null; original.ctx.lastBattleContext = { ...original.source.faceDance.battle, combatants: [...original.source.faceDance.battle.combatants], }; assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } }); void test('Face Dance public layers reject private identities, cards, skills and continuation fields', () => { const { ctx, source } = faceDance(); for (const field of ['leader', 'faceDancer', 'card', 'skills', 'continuation']) { for (const malformed of [ { ...source, [field]: 'private-payload' }, { ...source, faceDance: { ...source.faceDance, [field]: 'private-payload' } }, { ...source, faceDance: { ...source.faceDance, battle: { ...source.faceDance.battle, [field]: 'private-payload' } } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } } for (const malformed of [ { ...source, faceDance: null }, { ...source, faceDance: { ...source.faceDance, sources: null } }, { ...source, faceDance: { ...source.faceDance, returned: [] } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as unknown as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('Face Dance remains phase-six-only and does not alter existing producer JSON shapes or phase windows', () => { for (const original of [held(), transported(), gamont(false), battleResult(), homeworldTransport()]) { const before = JSON.stringify(original.source); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.equal(JSON.stringify(original.source), before); } for (const phase of [5, 8]) { const { ctx, source } = faceDance(); ctx.phase = phase; source.phase = phase; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); } }); void test('completed Face Dance validation never rereads availability, current dancers or private parent continuation', () => { const { ctx, source } = faceDance(); for (const player of ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers', 'reserves', 'moved', 'shipped']) { Object.defineProperty(player, field, { get() { throw new Error(`Face Dance helper read pretransfer or private ${player.id} ${field}`); }, }); } } for (const field of ['pendingFaceDance', 'pendingAutomaticAdvisorFaceDance', 'leaderSkills', 'continuation']) { Object.defineProperty(ctx, field, { get() { throw new Error(`Face Dance helper read private parent ${field}`); }, }); } for (const field of ['cardRoles', 'mandatoryDiscard', 'winnerDiscards', 'casualtyChoices', 'continuation']) { Object.defineProperty(ctx.lastBattleContext, field, { get() { throw new Error(`Face Dance helper read private battle ${field}`); }, }); } assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); }); function storm() { const ctx = context(); ctx.phase = 0; ctx.storm = 8; ctx.stormResolution = { from: 8, distance: 2, traversed: 1, pending: [] }; ctx.players[0].forces = { 'oh_gap:10': 2 }; ctx.players[1].forces = {}; ctx.players[2].forces = {}; const receipt: AutomaticAdvisorStorm = { event: 'public-current-sector-storm-event', from: 8, distance: 2, traversed: 1, sector: 9, }; const source: StormSource = { event: 'automatic-after-current-sector-casualties', owner: 'b', territory: 'oh_gap', turn: ctx.turn, phase: 0, forces: { 'oh_gap:10': 2 }, producer: 'storm', storm: receipt, }; ctx.players[0].advisors = { oh_gap: { lockedTurn: 4, aloneFlipHold: source.event } }; return { ctx, source }; } void test('the five-field public storm source binds current Oh Gap sector nine while surviving advisors remain in sector ten', () => { const original = storm(); const before = structuredClone(original); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.deepEqual(original, before); assert.deepEqual(Object.keys(original.source).sort(), ['event', 'forces', 'owner', 'phase', 'producer', 'storm', 'territory', 'turn']); assert.deepEqual(Object.keys(original.source.storm).sort(), ['distance', 'event', 'from', 'sector', 'traversed']); const quiet = storm().ctx; quiet.players[0].advisors = { oh_gap: { lockedTurn: 4 } }; assert.deepEqual(quoteAutomaticAdvisorFlips(quiet), [ { player: 'b', territory: 'oh_gap', forces: { 'oh_gap:10': 2 } }, ]); quiet.status = 'setup'; assert.deepEqual(quoteAutomaticAdvisorFlips(quiet), []); assert.equal(advisorStanceAfterSettlement({ advanced: true, players: quiet.players }, 'b', 'oh_gap'), undefined); for (const from of [0, 18]) { const wrapped = storm(); wrapped.ctx.storm = from; wrapped.source.storm = { ...wrapped.source.storm, from, distance: 40, traversed: 9, sector: 9 }; wrapped.ctx.stormResolution = { from, distance: 40, traversed: 9, pending: [] }; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(wrapped.ctx, wrapped.source)); } }); void test('storm conversion rejects stale public cursor, unfinished current-sector casualties and malformed traversal bounds', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: StormSource) => void)[] = [ (ctx) => { ctx.storm = 9; }, (ctx) => { delete ctx.storm; }, (ctx) => { ctx.stormResolution = null; }, (ctx) => { delete ctx.stormResolution; }, (ctx) => { ctx.stormResolution!.from = 9; }, (ctx) => { ctx.stormResolution!.distance = 3; }, (ctx) => { ctx.stormResolution!.traversed = 2; }, (ctx) => { ctx.stormResolution!.pending = ['private-fremen-casualty-key']; }, (ctx) => { ctx.status = 'setup'; }, (ctx) => { ctx.turn++; }, (_ctx, source) => { source.storm.event = ''; }, (_ctx, source) => { source.storm.from = -1; }, (_ctx, source) => { source.storm.from = 19; }, (_ctx, source) => { source.storm.from = 8.5; }, (_ctx, source) => { source.storm.distance = 0; }, (_ctx, source) => { source.storm.distance = 41; }, (_ctx, source) => { source.storm.distance = 2.5; }, (_ctx, source) => { source.storm.traversed = 0; }, (_ctx, source) => { source.storm.traversed = 3; }, (_ctx, source) => { source.storm.traversed = 1.5; }, (_ctx, source) => { source.storm.sector = 0; }, (_ctx, source) => { source.storm.sector = 19; }, (_ctx, source) => { source.storm.sector = 10; }, ]; for (const change of changes) { const original = storm(); change(original.ctx, original.source); const before = structuredClone(original); assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); assert.deepEqual(original, before); } const { ctx, source } = storm(); for (const malformed of [ { ...source, storm: null }, { ...source, storm: { ...source.storm, sector: '9' } }, { ...source, storm: { ...source.storm, forecast: 2 } }, { ...source, protected: true }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as unknown as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('protected Imperial Basin and unrelated or unknown territories cannot supply a storm occurrence', () => { const imperial = storm(); imperial.source.territory = 'imperial_basin'; imperial.source.forces = { 'imperial_basin:10': 2 }; imperial.ctx.players[0].forces = { 'imperial_basin:10': 2 }; imperial.ctx.players[0].advisors = { imperial_basin: { aloneFlipHold: imperial.source.event } }; assert.throws(() => validateAutomaticAdvisorFlip(imperial.ctx, imperial.source), AutomaticAdvisorFlipError); imperial.ctx.shieldWallDestroyed = true; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(imperial.ctx, imperial.source)); for (const territory of ['arrakeen', 'missing']) { const invalid = storm(); invalid.source.territory = territory; invalid.source.forces = { [`${territory}:10`]: 2 }; invalid.ctx.players[0].forces = { [`${territory}:10`]: 2 }; invalid.ctx.players[0].advisors = { [territory]: { aloneFlipHold: invalid.source.event } }; invalid.ctx.shieldWallDestroyed = true; assert.throws(() => validateAutomaticAdvisorFlip(invalid.ctx, invalid.source), AutomaticAdvisorFlipError); } }); void test('later storm traversal cannot reuse the old occurrence or restore an advisor group killed in its next sector', () => { const { ctx, source } = storm(); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); ctx.stormResolution!.traversed = 2; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); ctx.players[0].forces = {}; const before = structuredClone({ ctx, source }); assert.deepEqual(quoteAutomaticAdvisorFlips(ctx), []); assert.equal(advisorStanceAfterSettlement(ctx, 'b', 'oh_gap'), undefined); assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); assert.deepEqual({ ctx, source }, before); }); void test('storm public validation never reads forecasts, protection choices, private cards or pending Fremen keys', () => { const { ctx, source } = storm(); for (const field of ['stormCard', 'stormCardKnown', 'stormForecast', 'discoveryChoices', 'pendingAutomaticAdvisorStorm']) { Object.defineProperty(ctx, field, { get() { throw new Error(`Storm advisor rule read private or future ${field}`); }, }); } for (const field of ['protected', 'choamProtected', 'discoveryChoices', 'forecast']) { Object.defineProperty(ctx.stormResolution, field, { get() { throw new Error(`Storm advisor rule read private cursor ${field}`); }, }); } for (const player of ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers', 'stormForecast']) { Object.defineProperty(player, field, { get() { throw new Error(`Storm advisor rule read ${player.id} private ${field}`); }, }); } } assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); const pending = ['private-fremen-key']; Object.defineProperty(pending, '0', { get() { throw new Error('Storm advisor rule inspected a pending Fremen key'); }, }); ctx.stormResolution!.pending = pending; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); }); void test('storm stays phase-zero-only while every existing producer keeps its original receipt and phase', () => { for (const original of [held(), transported(), gamont(false), battleResult(), homeworldTransport(), faceDance()]) { const before = JSON.stringify(original.source); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.equal(JSON.stringify(original.source), before); original.ctx.phase = 0; original.source.phase = 0; assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } for (const phase of [5, 6, 8]) { const { ctx, source } = storm(); ctx.phase = phase; source.phase = phase; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); } }); function relocation(kind: AutomaticAdvisorRelocation['kind'] = 'ambassador', phase = kind === 'discovery' ? 0 : 5) { const { ctx, source: ground } = held(); ctx.phase = phase; ctx.players[0].forces = { 'imperial_basin:9': 2, 'imperial_basin:10': 1, 'arrakeen:10': 1 }; ctx.players[1].faction = kind === 'discovery' ? 'fremen' : 'atreides'; ctx.players[1].forces = { 'carthag:11': 1 }; const receipt: AutomaticAdvisorRelocation = { event: 'completed-public-special-relocation', kind, player: 'a', origin: 'imperial_basin', destination: 'carthag', sector: 11, }; const source: RelocationSource = { event: 'automatic-after-original-special-relocation', owner: ground.owner, territory: ground.territory, turn: ground.turn, phase, forces: ground.forces, producer: 'specialRelocation', relocation: receipt, }; ctx.players[0].advisors = { ...ctx.players[0].advisors, imperial_basin: { lockedTurn: 4, aloneFlipHold: source.event }, }; return { ctx, source }; } void test('Ambassador relocations retain exact six-field public receipts in all supported source phases and allow a BG arrival group', () => { for (const phase of [1, 3, 5, 8]) { const original = relocation('ambassador', phase); const before = structuredClone(original); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.deepEqual(original, before); assert.deepEqual(Object.keys(original.source).sort(), ['event', 'forces', 'owner', 'phase', 'producer', 'relocation', 'territory', 'turn']); assert.deepEqual(Object.keys(original.source.relocation).sort(), ['destination', 'event', 'kind', 'origin', 'player', 'sector']); } const arrival = relocation(); arrival.source.relocation.player = 'b'; arrival.source.relocation.destination = 'hagga_basin'; arrival.source.relocation.sector = 12; arrival.source.territory = 'hagga_basin'; arrival.source.forces = { 'hagga_basin:12': 2 }; arrival.ctx.players[0].forces = { 'hagga_basin:12': 2 }; arrival.ctx.players[0].advisors = { hagga_basin: { aloneFlipHold: arrival.source.event } }; arrival.ctx.players[1].forces = {}; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(arrival.ctx, arrival.source)); }); void test('Discovery relocation uses actual revealed interiors and the room board admits a placed HMS sector zero', () => { const discovery = relocation('discovery'); discovery.ctx.discoveries = { tokens: [{ face: 'cistern', status: 'placed', territory: 'hagga_basin', sector: 12, revealedTurn: 1 }], }; discovery.source.relocation.destination = 'cistern'; discovery.source.relocation.sector = 0; discovery.ctx.players[1].forces = { 'cistern:0': 1 }; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(discovery.ctx, discovery.source)); discovery.ctx.discoveries.tokens[0].revealedTurn = null; assert.throws(() => validateAutomaticAdvisorFlip(discovery.ctx, discovery.source), AutomaticAdvisorFlipError); discovery.ctx.discoveries.tokens[0].revealedTurn = 1; discovery.source.relocation.origin = 'cistern'; discovery.source.relocation.destination = 'carthag'; discovery.source.relocation.sector = 11; discovery.source.territory = 'cistern'; discovery.source.forces = { 'cistern:0': 2 }; discovery.ctx.players[0].forces = { 'cistern:0': 2 }; discovery.ctx.players[0].advisors = { cistern: { aloneFlipHold: discovery.source.event } }; discovery.ctx.players[1].forces = { 'carthag:11': 1 }; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(discovery.ctx, discovery.source)); const mobile = relocation(); mobile.ctx.players[1].faction = 'ixians'; mobile.ctx.mobileStronghold = { location: 'imperial_basin:9' }; mobile.source.relocation.destination = MOBILE_STRONGHOLD; mobile.source.relocation.sector = 0; mobile.ctx.players[1].forces = { [MOBILE_LOCATION]: 1 }; assert.doesNotThrow(() => validateAutomaticAdvisorFlip(mobile.ctx, mobile.source)); mobile.ctx.mobileStronghold.location = null; assert.throws(() => validateAutomaticAdvisorFlip(mobile.ctx, mobile.source), AutomaticAdvisorFlipError); }); void test('a relocated concealed No-Field supplies effective destination presence without exposing its denomination or identity', () => { const { ctx, source } = relocation(); source.relocation.player = 'r'; ctx.players[2].forces = {}; ctx.players[2].noField = { deployed: { location: { territory: 'carthag', sector: 11 } } }; for (const field of ['tokens', 'lastUsed', 'lastShipped', 'value']) { Object.defineProperty(ctx.players[2].noField, field, { get() { throw new Error(`Special relocation read hidden No-Field ${field}`); }, }); } for (const field of ['tokenId', 'value']) { Object.defineProperty(ctx.players[2].noField.deployed, field, { get() { throw new Error(`Special relocation read hidden deployed No-Field ${field}`); }, }); } assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); ctx.players[2].noField.deployed = null; assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); }); void test('special relocation rejects changed actor, current board locations, source binding, exact held group and private payloads', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: RelocationSource) => void)[] = [ (_ctx, source) => { source.relocation.event = ''; }, (_ctx, source) => { source.relocation.player = 'missing'; }, (ctx) => { ctx.players = [...ctx.players, { ...ctx.players[1] }]; }, (_ctx, source) => { source.relocation.origin = 'missing'; }, (_ctx, source) => { source.relocation.origin = 'homeworld:guild'; }, (_ctx, source) => { source.relocation.destination = 'homeworld:atreides'; }, (_ctx, source) => { source.relocation.destination = 'missing'; }, (_ctx, source) => { source.relocation.destination = 'carthag:11'; }, (_ctx, source) => { source.relocation.sector = -1; }, (_ctx, source) => { source.relocation.sector = 11.5; }, (_ctx, source) => { source.relocation.sector = 10; }, (_ctx, source) => { source.relocation.origin = 'hagga_basin'; }, (ctx) => { ctx.players[1].forces = {}; }, (ctx) => { ctx.players[1].forces = { 'arrakeen:10': 1 }; }, (ctx) => { ctx.players[0].forces = {}; }, (_ctx, source) => { source.forces = { 'imperial_basin:9': 3 }; }, ]; for (const change of changes) { const original = relocation(); change(original.ctx, original.source); const before = structuredClone(original); assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); assert.deepEqual(original, before); } const { ctx, source } = relocation(); for (const field of ['group', 'noField', 'tokenId', 'order', 'skills', 'signature', 'amount']) { for (const malformed of [ { ...source, [field]: 'private-original-state' }, { ...source, relocation: { ...source.relocation, [field]: 'private-original-state' } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } } for (const malformed of [ { ...source, relocation: null }, { ...source, relocation: { ...source.relocation, kind: 'worm' } }, { ...source, relocation: { ...source.relocation, sector: '11' } }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as unknown as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('relocation kind controls its own phases without widening any existing producer receipt or phase', () => { for (const original of [held(), transported(), gamont(false), battleResult(), homeworldTransport(), faceDance(), storm()]) { const before = JSON.stringify(original.source); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.equal(JSON.stringify(original.source), before); for (const phase of [1, 3]) { original.ctx.phase = phase; original.source.phase = phase; assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } } for (const phase of [0, 2, 4, 6, 7]) { const original = relocation('ambassador', phase); assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } for (const phase of [1, 3, 5, 6, 8]) { const original = relocation('discovery', phase); assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } for (const phase of [1, 3]) { const quiet = context(); quiet.phase = phase; assert.equal(quoteAutomaticAdvisorFlips(quiet).some((entry) => entry.territory === 'imperial_basin'), true); quiet.status = 'setup'; assert.deepEqual(quoteAutomaticAdvisorFlips(quiet), []); } }); void test('completed relocation validation never reads private parent signatures, hands, skills or original allowances', () => { for (const original of [relocation(), relocation('discovery')]) { for (const player of original.ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers', 'reserves', 'moved', 'shipped', 'skills']) { Object.defineProperty(player, field, { get() { throw new Error(`Special relocation read ${player.id} private or original ${field}`); }, }); } } for (const field of ['pendingAmbassador', 'pendingDiscoveryRelocation', 'pendingAutomaticAdvisorRelocation', 'movementOrder', 'leaderSkills']) { Object.defineProperty(original.ctx, field, { get() { throw new Error(`Special relocation read private parent ${field}`); }, }); } assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); } }); function spiritualArrival(amount = 1, phase = 5) { const ctx = context(); ctx.phase = phase; ctx.players[0].forces = { 'polar_sink:0': amount }; ctx.players[1].forces = {}; ctx.players[2].forces = {}; const receipt: SpiritualAdvisorSource = { event: 'original-public-spiritual-opportunity', owner: 'b', turn: ctx.turn, phase, territory: 'polar_sink', sector: 0, amount, }; const source: SpiritualArrivalSource = { event: 'automatic-after-completed-spiritual-placement', owner: 'b', territory: 'polar_sink', turn: ctx.turn, phase, forces: { 'polar_sink:0': amount }, producer: 'spiritualArrival', spiritual: receipt, }; ctx.players[0].advisors = { polar_sink: { aloneFlipHold: source.event } }; return { ctx, source }; } void test('a committed empty Spiritual Advisor placement retains its exact public source and surviving advisor group', () => { for (const phase of [1, 3, 5, 8]) { for (const amount of [1, 2]) { const original = spiritualArrival(amount, phase); const before = structuredClone(original); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.deepEqual(original, before); assert.deepEqual(Object.keys(original.source).sort(), ['event', 'forces', 'owner', 'phase', 'producer', 'spiritual', 'territory', 'turn']); assert.deepEqual(Object.keys(original.source.spiritual).sort(), ['amount', 'event', 'owner', 'phase', 'sector', 'territory', 'turn']); } } }); void test('Spiritual Arrival conversion rejects changed owner, target, phase, amount, deposit and physical group', () => { const changes: ((ctx: AutomaticAdvisorFlipContext, source: SpiritualArrivalSource) => void)[] = [ (_ctx, source) => { source.spiritual.event = ''; }, (_ctx, source) => { source.spiritual.owner = 'a'; }, (_ctx, source) => { source.spiritual.turn++; }, (_ctx, source) => { source.spiritual.phase = 6; }, (_ctx, source) => { source.spiritual.territory = 'arrakeen'; source.spiritual.sector = 10; }, (_ctx, source) => { source.spiritual.sector = 1; }, (_ctx, source) => { source.spiritual.amount = 2; }, (_ctx, source) => { source.spiritual.amount = 3; }, (ctx) => { ctx.players[0].forces = {}; }, (ctx) => { ctx.players[1].forces = { 'polar_sink:0': 1 }; }, (_ctx, source) => { source.forces = { 'polar_sink:0': 2 }; }, ]; for (const change of changes) { const original = spiritualArrival(); change(original.ctx, original.source); const before = structuredClone(original); assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); assert.deepEqual(original, before); } const { ctx, source } = spiritualArrival(); for (const malformed of [ { ...source, spiritual: null }, { ...source, spiritual: { ...source.spiritual, order: 'private-parent' } }, { ...source, spiritual: { ...source.spiritual, card: 'private-shipping-cost' } }, { ...source, spiritual: { ...source.spiritual, amount: '1' } }, { ...source, order: 'private-parent' }, ]) { assert.throws(() => validateAutomaticAdvisorFlip(ctx, malformed as unknown as AutomaticAdvisorFlipSource), AutomaticAdvisorFlipError); } }); void test('an already-held continuously-alone group stays advisors after another Spiritual Advisor joins without earning a fresh automatic response', () => { const { ctx, source } = spiritualArrival(); ctx.players[0].forces = { 'polar_sink:0': 3 }; source.forces = { 'polar_sink:0': 3 }; ctx.players[0].advisors = { polar_sink: { aloneFlipHold: 'earlier-prevented-alone-occurrence' } }; assert.deepEqual(spiritualAdvisorArrival(ctx, 'b', 'polar_sink'), { advisors: true, matching: false, alone: true }); assert.deepEqual(quoteAutomaticAdvisorFlips(ctx), []); assert.deepEqual(advisorStanceAfterSettlement(ctx, 'b', 'polar_sink'), { aloneFlipHold: 'earlier-prevented-alone-occurrence', }); assert.throws(() => validateAutomaticAdvisorFlip(ctx, source), AutomaticAdvisorFlipError); }); void test('Spiritual Arrival leaves all prior producer receipts and phases unchanged and rejects unsupported or Basic conversion windows', () => { for (const original of [held(), transported(), gamont(false), battleResult(), homeworldTransport(), faceDance(), storm(), relocation(), relocation('discovery')]) { const before = JSON.stringify(original.source); assert.doesNotThrow(() => validateAutomaticAdvisorFlip(original.ctx, original.source)); assert.equal(JSON.stringify(original.source), before); } for (const phase of [0, 2, 4, 6, 7]) { const original = spiritualArrival(1, phase); assert.throws(() => validateAutomaticAdvisorFlip(original.ctx, original.source), AutomaticAdvisorFlipError); } const basic = spiritualArrival(); basic.ctx.advanced = false; assert.throws(() => validateAutomaticAdvisorFlip(basic.ctx, basic.source), AutomaticAdvisorFlipError); }); void test('Spiritual Arrival conversion uses only public receipt, current deposit and held group without reading resources or the private original frame', () => { const { ctx, source } = spiritualArrival(2); for (const player of ctx.players) { for (const field of ['hand', 'leaders', 'spice', 'traitors', 'faceDancers', 'reserves', 'moved', 'shipped']) { Object.defineProperty(player, field, { get() { throw new Error(`Spiritual conversion read ${player.id} private or original ${field}`); }, }); } } for (const field of ['pendingSpiritualAdvisor', 'pendingShipment', 'stormCard', 'stormForecast', 'leaderSkills', 'homeworlds']) { Object.defineProperty(ctx, field, { get() { throw new Error(`Spiritual conversion read private parent ${field}`); }, }); } assert.doesNotThrow(() => validateAutomaticAdvisorFlip(ctx, source)); });