Files
Dune/docs/HAND_BROWSING.md
T
Quintine e3cfd82540 Add private-hand search, category filters and display sorting
Wrap existing physical hand cards with local name search, printed-category
filters and saved/name/category display order. Preserve card IDs, actions and
inspectors, keep required decisions outside filtering, and recompute results
from current owned cards. Provide count, clear filters, keyboard scrolling,
separate empty/no-match states and internal guidance. Filters reset on leaving
the hand tab, changing seats or refreshing; saved order is never modified.
Correct the stale Harass availability note to reflect connected allocation.

Six focused tests cover normalized literal search, duplicate physical IDs,
canonical expansion categories, stable immutable sorting, current holdings,
JSON restoration, full-table per-seat privacy and empty setup messaging.
Independent review found no material issue. Types, lint, all 4996 offline
tests and production build pass on stable source. No HTTP, auth, schema or
persistence implementation changed, so HTTP tests were not repeated.

Browser QA used a new two-player Basic Harkonnen/Easy Atreides game created
through genuine setup. Search/category/reset, named inspector and all three
sort orders worked. An active no-match filter updated from 0 of 2 to 0 of 4
when a real auction purchase and Harkonnen bonus arrived. Leaving the hand tab
and refreshing restored all four cards in their original saved order while
the second auction remained at a human decision. Enter in search performed
no game action. The internal guide worked by keyboard. At 390px, controls
were 44px high with 16px text and 14px labels, form width/scroll width 339px;
the focused overflowing card row responded to ArrowRight. Normal viewport
restored. Screenshot capture timed out; full visual/screen-reader acceptance
and complete expansion/card-effect combinations remain open.

All 1538 opening rooms, 3258 seats and auxiliary rows
remain unchanged. SQLite integrity and foreign keys pass. Only one isolated
QA game, its human seat and entry receipt were added; the AI remains in game state. Healthy server reused without restart,
migration, reset or automation. No AI strategy or mode/publication gate changed.

Private evidence: 20260921-hand-browsing.
Verified source tree: 39dce28efa52dd66baf019baaf8610e6795601b3b569ac4ac0b6f405bffc1d96
2026-09-21 12:00:34 +10:00

2.7 KiB
Raw Blame History

Private hand browsing

Connected prototype, 21 September 2026. Name search, printed-category filtering and display sorting now wrap the existing private hand cards. This adds a usable browsing function without changing card actions or rule-completion gates.

Behavior

HandBrowser receives only me.hand. browseHand creates a display array with the same physical card objects/IDs; it never sorts the saved hand in place. Names match literally, ignoring case, surrounding whitespace and accents. The shared printedCardCategory supplies the primary category, including canonical expansion cards. It does not determine dynamic battle-slot or faction legality.

Players choose saved hand order, name A–Z or primary category followed by name. Duplicate names remain separate and keep relative order. The result count and Show all cards make filtered-out cards reachable. Clearing removes both filters and retains the display sort. Empty hands retain the existing setup or empty-hand explanation; no-match results have a separate recovery message.

The full card-render callback is reused with its physical-ID actions and inspectors. Dedicated effect panels and mandatory choices remain outside the filtered row. The scrollable row is keyboard-focusable, and Enter in the search form cannot submit a game action. Native inputs and reset controls have 44px minimum height; control text is 16px and labels 14px.

Filters stay in component memory. The room/seat key and leaving the hand tab reset them, as does refresh. Current props drive every result, so removed cards are not retained and new cards update the total even under an active filter. There are no new endpoints, saved fields, credentials, storage, AI strategies or hidden-information projections. Existing saved continuation remains shared.

The card presentation also corrects a stale Harass & Withdraw availability note: revealed physical allocation is connected. Richese and other unresolved combinations remain guarded; no additional rule is enabled.

Evidence and limits

Focused tests cover literal/normalized names, duplicate IDs, canonical expansion categories, stable immutable sorting, current-card removal/acquisition and JSON restoration. Full-table rendering checks that each seat receives only its own inspectors while controls are busy, plus the undealt empty-state explanation. Use npm test -- hand-brows.

Independent review, source-bound browser observations, final type/lint/offline checks and build, saved-game preservation and Git delivery belong to the private checkpoint. Browser samples and selection tests do not certify all card effects, full visual accessibility or expansion combinations. Generic discard browsing and manual drag-reordering remain outside this checkpoint.