Files
Dune/tests/discovery-collection.test.ts
T
Quintine ab0ab52849 Prototype Discovery free entry, Cistern income and carried flight
Connect next-turn optional entry before storm/HMS movement, with typed
multi-sector groups, normal source-storm/occupancy checks, legal bot and human
choices, signed saved arrivals and Bene Gesserit reaction continuation.
Cistern pays its sole occupant two bank spice through canonical Collection.
A carried Ornithopter grants fixed range three on a later-turn actual movement,
preserves pending responses and independent Treachery/No-Field custody, and is
removed only after the selected group moves.

Independent reviews bind pending entry destination baselines, typed custody and
exact reaction continuations. Browser QA caught and fixed an incorrect decision
heading. Orgiz remains disabled pending the stacked-Blow ruling; Jacurutu battle
income, Ecological Testing Station and Shrine remain missing. Mode and publication
gates stay closed; this checkpoint does not certify full Discovery compliance.

Verification: types/lint and 4,313 offline tests passed (49 added), production
build passed, and 40 HTTP tests passed. Final stable run durations: check
139145ms, build 6530ms, integration 24421ms. An earlier run found one stale
Discovery notice assertion, now updated; the next run was interrupted by a
user-confirmed power outage. No interrupted result is claimed as success.

Targeted browser room CA782FQE used genuine human Atreides and two-AI setup,
then physical QA positioning for partial free entry and a three-territory
Ornithopter move. Refresh preserved its private hand, forces, spice and token
removal. The power outage stopped both server and checks; the absent server was
restarted after a private backup. The same browser seat restored correctly and
all 157 pre-restart rooms were unchanged. Final preservation: all 156 opening
rooms unchanged, 31 added QA/integration rooms, total 187. No database reset.

Source fingerprint:
7b639d7f6559a88b00f3cbf913cfa7e6c400bfabb8c392e7b732e8ea77f6dcbc
Private report:
/home/quintine/.local/share/dune/checkpoints/20260913-discovery-entry-flight/verification-recovered/report.json
Aggregate goal counter 61,819,586 -> 63,110,032 at completed verification:
1,290,446 tokens before final Git overhead for three connected functions,
including helper coordination, reviews, browser QA and interrupted checks.
2026-09-13 14:13:40 +10:00

419 lines
12 KiB
TypeScript

import test from 'node:test';
import assert from 'node:assert/strict';
import { quoteSpiceCollection } from '../game/board-resolution-quote';
import { baseDeck } from '../game/cards';
import type { FactionId } from '../game/catalog';
import {
createDiscoveryState,
validateDiscoveryState,
type DiscoveryLocationId,
} from '../game/discoveries';
import {
CISTERN,
ORGIZ_PROCESSING_STATION,
quoteDiscoveryCollection,
} from '../game/discovery-collection';
import {
applyAction,
createGame,
newPlayer,
normalizeAutomaticGame,
type Game,
} from '../game/engine';
type Seat = [id: string, faction: FactionId];
function fixture(
advanced = false,
seats: Seat[] = [
['a', 'atreides'],
['h', 'harkonnen'],
['g', 'guild'],
],
): Game {
const [first, ...rest] = seats;
const game = createGame(
'DISCOVERYCOLLECTION',
newPlayer(first[0], first[0], first[1]),
advanced,
);
game.players.push(...rest.map(([id, faction]) => newPlayer(id, id, faction)));
Object.assign(game, {
status: 'playing',
phase: 7,
turn: 2,
storm: 18,
order: seats.map(([id]) => id),
spice: {},
discoveries: createDiscoveryState(() => 0),
});
for (const player of game.players) {
player.forces = {};
player.spice = 0;
}
return game;
}
function reveal(game: Game, id: DiscoveryLocationId) {
const token = game.discoveries!.tokens.find((entry) => entry.face === id)!;
const smuggler = token.type === 'smuggler';
Object.assign(token, {
status: 'placed',
territory: smuggler ? 'pasty_mesa' : 'meridian',
sector: smuggler ? 7 : 1,
revealedTurn: 2,
});
validateDiscoveryState(game.discoveries!);
}
function composed(game: Game, orgizObservableDeposits = false) {
const ordinary = quoteSpiceCollection(game);
return {
ordinary,
discovery: quoteDiscoveryCollection(
game,
ordinary,
orgizObservableDeposits ? { orgizObservableDeposits: true } : {},
),
};
}
function balance(
quote: ReturnType<typeof quoteDiscoveryCollection>,
player: string,
) {
return quote.receipts.find((receipt) => receipt.player === player)!.balance;
}
void test('a sole Cistern occupant receives two bank spice in Basic and Advanced without changing collection facts', () => {
for (const advanced of [false, true]) {
const game = fixture(advanced);
reveal(game, CISTERN);
game.players[0].forces = { [`${CISTERN}:0`]: 1 };
game.players[0].spice = 4;
const before = structuredClone(game);
const { ordinary, discovery } = composed(game);
assert.deepEqual(discovery.effects, [
{
kind: 'cistern',
player: 'a',
amount: 2,
source: 'bank',
},
]);
assert.equal(
balance(discovery, 'a'),
balance({ ...discovery, receipts: ordinary.receipts }, 'a') + 2,
);
assert.deepEqual(
discovery.receipts.map(({ player, collected, desert, strongholds }) => ({
player,
collected,
desert,
strongholds,
})),
ordinary.receipts.map(({ player, collected, desert, strongholds }) => ({
player,
collected,
desert,
strongholds,
})),
);
assert.deepEqual(game, before);
}
});
void test('Cistern requires non-advisor occupation and has no effect while unrevealed or empty', () => {
const hidden = fixture(true);
const hiddenToken = hidden.discoveries!.tokens.find(
(entry) => entry.face === CISTERN,
)!;
Object.assign(hiddenToken, {
status: 'placed',
territory: 'meridian',
sector: 1,
});
assert.deepEqual(composed(hidden).discovery.effects, []);
const advisors = fixture(true, [
['b', 'beneGesserit'],
['h', 'harkonnen'],
]);
reveal(advisors, CISTERN);
advisors.players[0].forces = { [`${CISTERN}:0`]: 1 };
advisors.players[0].advisors = { [CISTERN]: {} };
assert.deepEqual(composed(advisors).discovery.effects, []);
});
void test('the bounded Orgiz quote transfers one spice from each uniquely collected observable board deposit', () => {
const game = fixture();
reveal(game, ORGIZ_PROCESSING_STATION);
game.players[0].forces = {
[`${ORGIZ_PROCESSING_STATION}:0`]: 1,
'red_chasm:7': 1,
};
game.players[1].forces = { 'hagga_basin:12': 1 };
game.players[2].forces = { 'cielago_south:2': 1 };
game.spice = {
'red_chasm:7': 2,
'hagga_basin:12': 4,
'cielago_south:2': 3,
};
const before = structuredClone(game);
const { ordinary, discovery } = composed(game, true);
assert.deepEqual(discovery.effects, [
{
kind: 'orgiz',
player: 'a',
from: 'g',
location: 'cielago_south:2',
amount: 1,
source: 'player',
},
{
kind: 'orgiz',
player: 'a',
from: 'h',
location: 'hagga_basin:12',
amount: 1,
source: 'player',
},
]);
assert.equal(
balance(discovery, 'a'),
balance({ ...discovery, receipts: ordinary.receipts }, 'a') + 2,
);
assert.equal(
balance(discovery, 'h'),
balance({ ...discovery, receipts: ordinary.receipts }, 'h') - 1,
);
assert.equal(
balance(discovery, 'g'),
balance({ ...discovery, receipts: ordinary.receipts }, 'g') - 1,
);
assert.equal(
discovery.receipts.reduce((sum, receipt) => sum + receipt.balance, 0),
ordinary.receipts.reduce((sum, receipt) => sum + receipt.balance, 0),
);
assert.deepEqual(game, before);
assert.deepEqual(quoteSpiceCollection(game), ordinary);
});
void test('Orgiz does not transfer spice from its occupant to itself and ignores untouched deposits', () => {
const game = fixture();
reveal(game, ORGIZ_PROCESSING_STATION);
game.players[0].forces = {
[`${ORGIZ_PROCESSING_STATION}:0`]: 1,
'red_chasm:7': 1,
};
game.players[1].forces = { 'hagga_basin:12': 1 };
game.spice = {
'red_chasm:7': 2,
'hagga_basin:12': 2,
'cielago_south:2': 6,
};
const disabled = quoteDiscoveryCollection(game, quoteSpiceCollection(game));
assert.deepEqual(disabled.effects, []);
assert.deepEqual(disabled.receipts, quoteSpiceCollection(game).receipts);
const { ordinary, discovery } = composed(game, true);
assert.deepEqual(discovery.effects, [
{
kind: 'orgiz',
player: 'a',
from: 'h',
location: 'hagga_basin:12',
amount: 1,
source: 'player',
},
]);
assert.equal(
balance(discovery, 'a'),
balance({ ...discovery, receipts: ordinary.receipts }, 'a') + 1,
);
assert.equal(discovery.receipts[0].collected, ordinary.receipts[0].collected);
assert.equal(discovery.receipts[0].desert, ordinary.receipts[0].desert);
});
void test('Orgiz retains unresolved Ecaz shared custody instead of creating or assigning spice', () => {
const game = fixture(false, [
['e', 'ecaz'],
['a', 'atreides'],
['g', 'guild'],
]);
reveal(game, ORGIZ_PROCESSING_STATION);
game.players[0].ally = 'a';
game.players[1].ally = 'e';
game.players[0].forces = { 'hagga_basin:12': 1 };
game.players[1].forces = { 'hagga_basin:12': 1 };
game.players[2].forces = { [`${ORGIZ_PROCESSING_STATION}:0`]: 1 };
game.spice = { 'hagga_basin:12': 4 };
const ordinary = quoteSpiceCollection(game);
assert.deepEqual(ordinary.shared, [
{ territory: 'hagga_basin', ecaz: 'e', ally: 'a', amount: 4 },
]);
const before = structuredClone({ game, ordinary });
assert.throws(
() =>
quoteDiscoveryCollection(game, ordinary, {
orgizObservableDeposits: true,
}),
/unresolved Ecaz shared lot/,
);
assert.deepEqual({ game, ordinary }, before);
});
void test('a contested Cistern retains the unresolved bonus without blocking collection', () => {
const game = fixture(false, [
['e', 'ecaz'],
['a', 'atreides'],
['g', 'guild'],
]);
reveal(game, CISTERN);
game.players[0].ally = 'a';
game.players[1].ally = 'e';
game.players[0].forces = { [`${CISTERN}:0`]: 1 };
game.players[1].forces = { [`${CISTERN}:0`]: 1 };
const ordinary = quoteSpiceCollection(game);
const before = structuredClone({ game, ordinary });
assert.deepEqual(quoteDiscoveryCollection(game, ordinary), {
receipts: ordinary.receipts,
effects: [],
});
assert.deepEqual({ game, ordinary }, before);
});
void test('the real collection phase credits Cistern once and preserves the receipt through JSON recovery', () => {
const game = fixture(false);
game.discoveryEnabled = true;
reveal(game, CISTERN);
Object.assign(game, {
phase: 5,
active: 'g',
movementRemaining: ['g'],
phaseOpening: null,
});
for (const player of game.players)
Object.assign(player, {
hand: [],
traitors: [],
traitorChoices: [],
shipped: true,
moved: 1,
reserves: 20,
});
game.players[0].forces = { [`${CISTERN}:0`]: 1 };
game.players[0].forces['red_chasm:7'] = 1;
game.players[0].reserves = 18;
game.players[0].spice = 4;
game.spice = { 'red_chasm:7': 2 };
const before = structuredClone(game);
const ordinary = quoteSpiceCollection(game);
assert.equal(
ordinary.receipts.find((receipt) => receipt.player === 'a')!.balance,
6,
);
let collected = applyAction(game, 'g', { type: 'endMovement' });
assert.deepEqual(game, before);
assert.equal(collected.phase, 7);
assert.equal(collected.players.find((player) => player.id === 'a')!.spice, 8);
assert.equal(collected.spice['red_chasm:7'], 0);
assert.equal(
collected.log.filter((entry) =>
entry.text.includes(
'received 2 spice from the bank for occupying Cistern',
),
).length,
1,
);
collected = JSON.parse(JSON.stringify(collected)) as Game;
assert.deepEqual(normalizeAutomaticGame(collected), collected);
assert.equal(collected.players.find((player) => player.id === 'a')!.spice, 8);
assert.equal(
collected.log.filter((entry) => entry.automatic?.name === 'Cistern').length,
1,
);
});
void test('a saved Ecaz response commits Cistern once only after the collection response resolves', () => {
const game = createGame(
'DISCOVERYECAZCOLLECTION',
newPlayer('ec', 'Ecaz', 'ecaz'),
true,
['ecaz'],
);
game.players.push(
newPlayer('al', 'Ally', 'atreides'),
newPlayer('en', 'Rival', 'emperor'),
);
Object.assign(game, {
status: 'playing',
phase: 5,
turn: 2,
storm: 18,
order: ['ec', 'al', 'en'],
active: 'en',
movementRemaining: ['en'],
phaseOpening: null,
spice: {},
deck: baseDeck(),
discard: [],
discoveryEnabled: true,
discoveries: createDiscoveryState(() => 0),
});
reveal(game, CISTERN);
for (const player of game.players)
Object.assign(player, {
spice: 10,
hand: [],
traitors: [],
traitorChoices: [],
forces: {},
reserves: 20,
shipped: true,
moved: 1,
});
game.players[0].ally = 'al';
game.players[1].ally = 'ec';
game.players[0].allySinceTurn = 1;
game.players[1].allySinceTurn = 1;
game.players[0].forces = { 'arrakeen:10': 1 };
game.players[1].forces = { 'arrakeen:10': 1 };
game.players[2].forces = { [`${CISTERN}:0`]: 1 };
for (const player of game.players) player.reserves = 19;
const karama = game.deck.findIndex((card) => card.name === 'Karama');
assert.ok(karama >= 0);
game.players[2].hand.push(game.deck.splice(karama, 1)[0]);
let collected = applyAction(game, 'en', { type: 'endMovement' });
assert.equal(collected.response?.kind, 'ecazCollection');
assert.equal(collected.players[2].spice, 10);
assert.equal(
collected.log.filter((entry) => entry.automatic?.name === 'Cistern').length,
0,
);
collected = JSON.parse(JSON.stringify(collected)) as Game;
for (let count = 0; collected.response && count < 10; count++) {
const responder = collected.players.find(
(player) => !collected.response!.passed.includes(player.id),
)!;
collected = applyAction(collected, responder.id, { type: 'passResponse' });
}
assert.equal(collected.response, null);
assert.equal(collected.players[2].spice, 12);
assert.equal(
collected.log.filter((entry) => entry.automatic?.name === 'Cistern').length,
1,
);
collected = JSON.parse(JSON.stringify(collected)) as Game;
assert.deepEqual(normalizeAutomaticGame(collected), collected);
assert.equal(collected.players[2].spice, 12);
assert.equal(
collected.log.filter((entry) => entry.automatic?.name === 'Cistern').length,
1,
);
});