Files
Dune/tests/seat-handover-client.test.ts
T
Quintine 7dfd6b3048 Prototype voluntary seat handover with durable private retries
Let a current owner issue, cancel or replace a private 24-hour one-time offer.
Recipients accept the same faction and saved game while old browser sessions,
recovery keys and entry receipts lose authority. Preserve exact claim retries
across refresh, restart and later offers, with private tab-scoped continuation.

Fence every claim mutation to its winning transaction. Add durable receipts
and additive backfill for already-issued offers without changing game JSON or
existing seat authority. Block competing navigation during unresolved owner
operations; remove invalidated owner kits on confirmed recovery.

Record the pending CHOAM Nexus after-victory secrecy/window decision without
inventing the unresolved gameplay or opening mode/publication gates.

Validation: types/lint and 4,364 offline tests passed; production build passed;
43 HTTP tests passed. Added 19 offline and 3 HTTP regressions. Independent
privacy/persistence review passed, including deterministic CAS interleavings,
rollback, legacy migration and exact receipt restoration. Browser room 2EMYG4CY
retained private setup choices after handover/refresh and continued into Storm;
follow-up recovery removed its invalid offer with cards/forces/spice unchanged.
All 218 opening rooms preserved (291 after QA and both broad runs). The opening
456 seat, 49 recovery-key, 56 recovery-receipt and 106 entry-receipt rows were
also verified unchanged. Server reused; no restart or recurring automation.

Final private report: ~/.local/share/dune/checkpoints/20260913-seat-handover/
verification-final/report.json. Source fingerprint:
8949cdf58eb8bc8bd33f2657c6b21352b3ee5e17e2a556c684a89073015632f4.
Check/build/HTTP duration: 140565/6689/24835 ms. The earlier broad run passed;
a final recovery-UI review fix required the second source-bound run.
Goal aggregate counter 64,301,976 -> 65,031,751 before Git (729,775) for this
bounded capability and its concurrency/recovery review; full goal remains active.
2026-09-13 15:28:14 +10:00

175 lines
5.6 KiB
TypeScript

import test from 'node:test';
import assert from 'node:assert/strict';
import {
HANDOVER_CLAIM_STORAGE_KEY,
clearHandoverClaim,
clearHandoverOwner,
createHandoverClaim,
createHandoverKit,
handoverClaimConfirmed,
handoverOwnerStorageKey,
parseHandoverClaim,
parseHandoverKit,
saveHandoverClaim,
serializeHandoverKit,
} from '../lib/seat-handover';
const player = '93c66e7c-2d3b-4845-aedf-5d1f06cf3371';
const kit = () => createHandoverKit('ABCD2345', player);
const storage = () => {
const entries = new Map<string, string>();
return {
getItem: (key: string) => entries.get(key) ?? null,
setItem: (key: string, value: string) => {
entries.set(key, value);
},
removeItem: (key: string) => {
entries.delete(key);
},
};
};
void test('confirmed recovery removes only the invalidated owner offer and verifies cleanup before restoring the UI', () => {
const saved = storage(),
key = handoverOwnerStorageKey('ABCD2345', player);
const other = handoverOwnerStorageKey('BCDE2345', player);
saved.setItem(key, 'old private offer');
saved.setItem(other, 'another room offer');
saved.setItem(HANDOVER_CLAIM_STORAGE_KEY, 'unrelated pending claim');
clearHandoverOwner(saved, 'ABCD2345', player);
assert.equal(saved.getItem(key), null);
assert.equal(saved.getItem(other), 'another room offer');
assert.equal(
saved.getItem(HANDOVER_CLAIM_STORAGE_KEY),
'unrelated pending claim',
);
assert.throws(() =>
clearHandoverOwner(
{ getItem: () => 'old private offer', removeItem() {} },
'ABCD2345',
player,
),
);
});
void test('handover kits have fresh secure one-time offer identities and strict round-trip format', () => {
const a = kit(),
b = kit();
assert.deepEqual(parseHandoverKit(serializeHandoverKit(a)), a);
assert.notEqual(a.offerId, b.offerId);
assert.notEqual(a.handoverSecret, b.handoverSecret);
assert.match(a.handoverSecret, /^[0-9a-f]{64}$/);
assert.ok(Object.isFrozen(a));
});
void test('kits reject substituted recovery formats, secret-bearing URLs and injected fields without echoing inputs', () => {
const a = kit();
for (const text of [
'null',
'[]',
'{',
'x'.repeat(4097),
...[
{ ...a, format: 'dune-seat-recovery' },
{ ...a, roomCode: 'https://evil.test' },
{ ...a, playerId: 'host' },
{ ...a, handoverSecret: 'secret-to-not-echo' },
{ ...a, newSessionToken: 'ff'.repeat(32) },
{ ...a, version: 2 },
].map((value) => JSON.stringify(value)),
]) {
assert.throws(
() => parseHandoverKit(text),
(error) =>
error instanceof Error && !error.message.includes('secret-to-not-echo'),
);
}
});
void test('refresh restores exactly the same claim proof and prevents a second claim from replacing it', () => {
const a = createHandoverClaim(kit()),
saved = storage();
saveHandoverClaim(saved, a);
const restored = parseHandoverClaim(
saved.getItem(HANDOVER_CLAIM_STORAGE_KEY)!,
);
assert.deepEqual(restored, a);
assert.equal(JSON.stringify(restored.attempt), JSON.stringify(a.attempt));
assert.ok(Object.isFrozen(restored.attempt));
assert.notEqual(a.attempt.newSessionToken, a.kit.handoverSecret);
saveHandoverClaim(saved, restored);
assert.throws(() => saveHandoverClaim(saved, createHandoverClaim(a.kit)));
assert.deepEqual(
parseHandoverClaim(saved.getItem(HANDOVER_CLAIM_STORAGE_KEY)!),
a,
);
clearHandoverClaim(saved);
assert.equal(saved.getItem(HANDOVER_CLAIM_STORAGE_KEY), null);
});
void test('saved claim validation rejects altered bindings, reused secrets and unexpected authority fields', () => {
const a = createHandoverClaim(kit());
for (const value of [
{ ...a, extra: true },
{ ...a, attempt: { ...a.attempt, playerId: crypto.randomUUID() } },
{ ...a, attempt: { ...a.attempt, offerId: crypto.randomUUID() } },
{ ...a, attempt: { ...a.attempt, newSessionToken: a.kit.handoverSecret } },
{ ...a, attempt: { ...a.attempt, operationId: 'again' } },
{ ...a, attempt: { ...a.attempt, host: true } },
])
assert.throws(() => parseHandoverClaim(JSON.stringify(value)));
});
void test('unavailable or silently dropping browser storage cannot confirm saved or removed retry proof', () => {
const a = createHandoverClaim(kit());
assert.throws(() =>
saveHandoverClaim({ getItem: () => null, setItem() {} }, a),
);
assert.throws(() =>
saveHandoverClaim(
{
getItem: () => null,
setItem() {
throw new Error('blocked');
},
},
a,
),
);
assert.throws(() =>
clearHandoverClaim({ getItem: () => JSON.stringify(a), removeItem() {} }),
);
});
void test('a claimed seat is confirmed only after receipt and cookie-authorized read both identify the intended seat', () => {
const a = createHandoverClaim(kit());
const view = {
code: a.kit.roomCode,
me: player,
version: 4,
players: [{ id: player }],
};
const response = { view, transferred: true, replayed: false };
assert.ok(handoverClaimConfirmed(a, response, view));
assert.ok(
handoverClaimConfirmed(
a,
{ ...response, replayed: true },
{ ...view, version: 9 },
),
);
assert.equal(handoverClaimConfirmed(a, { view }, view), false);
assert.equal(
handoverClaimConfirmed(a, response, { ...view, me: crypto.randomUUID() }),
false,
);
assert.equal(
handoverClaimConfirmed(
a,
{ ...response, view: { ...view, code: 'BCDE2345' } },
view,
),
false,
);
assert.equal(
handoverClaimConfirmed(a, response, { ...view, players: [] }),
false,
);
assert.equal(
handoverClaimConfirmed(a, response, { ...view, version: 3 }),
false,
);
});