byd: fix canError ("Unknown Vehicle Variant") from strict parser alive checks
Explicit parser frequencies made canValid=False when state-dependent messages are absent (PCM_BUTTONS is event-driven; MPC_LKAS_CMD/ACC_CMD only flow when stock ADAS is active), tripping EventName.canError. - Alive-check only control-critical messages, at a conservative 10Hz (1s timeout): ESC, BRAKE_APPLIED, PEDAL, STEER_MODULE, STEERING_TORQUE, DRIVE_STATE, ACC_HUD_ADAS - Parse-but-don't-alive-check (nan) the rest: STALKS, METER_CLUSTER, MPC_LKAS_CMD, ACC_CMD - PCM_BUTTONS is parsed on both pt and cam parsers (bus assignment is harness dependent); MADS reads LKAS_ON_BTN from whichever bus sees it Verified: canValid=True with idle stock ADAS, LKAS button events work from either bus, canValid stays True throughout.
This commit is contained in:
1 parent
1a4f296aa8
commit
bd58431b9b
4 files changed
+195
-13
No files matched your search
@@ -19,6 +19,12 @@ class MadsCarState(MadsCarStateBase):
|
||||
|
||||
def update_mads(self, ret: structs.CarState, can_parsers: dict[StrEnum, CANParser]) -> None:
|
||||
cp = can_parsers[Bus.pt]
|
||||
cp_cam = can_parsers[Bus.cam]
|
||||
|
||||
# PCM_BUTTONS bus assignment is harness dependent; read from whichever bus sees it
|
||||
lkas_button = cp.vl["PCM_BUTTONS"]["LKAS_ON_BTN"]
|
||||
if not cp.vl_all["PCM_BUTTONS"]["LKAS_ON_BTN"] and cp_cam.vl_all["PCM_BUTTONS"]["LKAS_ON_BTN"]:
|
||||
lkas_button = cp_cam.vl["PCM_BUTTONS"]["LKAS_ON_BTN"]
|
||||
|
||||
self.prev_lkas_button = self.lkas_button
|
||||
self.lkas_button = cp.vl["PCM_BUTTONS"]["LKAS_ON_BTN"]
|
||||
self.lkas_button = lkas_button
|
||||
Reference in new issue
Block a user